PROBLEM: Unselectable code in ./arch/m68k/sun3/prom/init.c

DISCUSSION Geert Uytterhoeven 1 participant 1 message Jun 20, 2012 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Geert Uytterhoeven

author

2012-06-20 14:04 UTC #1 lore raw

Hi Sarah,

Quoted 13 lines · Sarah Nadi

Summary: Code block dead in ./arch/m68k/sun3/prom/init.c because file only gets compiled if CONFIG_SUN3 is enabled.
Problem Description:
Code block below in file ./arch/m68k/sun3/prom/init.c is only compiled if CONFIG_SUN3 is not enabled, while the file is compiled if CONFIG_SUN3 is enabled which means that this code block is dead. Seems that this block has always been around, and still exists in the latest release.
In ./arch/m68k/Makefile: core-$(CONFIG_SUN3) += arch/m68k/sun3/ arch/m68k/sun3/prom/
In ./arch/m68k/sun3/prom/init.c :

Quoted 6 lines

#ifndef CONFIG_SUN3
switch(romvec->pv_romvers) {
#endif
Should this code be removed, or should the condition be changed?

Thanks! This code was copied from SPARC, but isn't relevant for the supported Sun-3 platforms. I'll remove it.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds