Skip to contentSkip to conversation

a typo in runltp script

LTP Li, Jin 3 participants 3 messages Jun 21, 2012 – Jun 22, 2012

lore
Share & tools
lore

Li, Jin

author
#0 lore raw

Hi,

When I use runltp with the option [-b DEVICE], notice the typo as follows:

sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests

The runltp will hit error and exit.

Is it a typo or I miss something else ?

Thanks,

Jin

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw

Hi!

Quoted 7 lines

When I use runltp with the option [-b DEVICE], notice the typo as follows:

sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests

The runltp will hit error and exit.

Is it a typo or I miss something else ?

That line went in with Garrett's patch to improve the script. I guess he was using slightly different version of sed (or just typed the line wrong). (CCed him in case he remebers).

And in any case we should fix that. Do you care to send a patch?

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#2 lore raw
In reply to Li, Jin
Quoted 9 lines · Jin

Hi,

When I use runltp with the option [-b DEVICE], notice the typo as follows:

sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|"  ${TMP}/alltests

The runltp will hit error and exit.

Is it a typo or I miss something else ?

It wasn't an intentional "typo". It's an inconsistency between BSD
sed and GNU sed (something that irritates me from time to time). The above form works with BSD sed.

    Replacing `-i ""` with `-i '.bk'` should work.

Thanks,
-Garrett

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list