Wrong common field name in GFX Wakeups event

Powertop Igor Zhbanov 2 participants 3 messages Jul 11, 2012 – Jul 17, 2012

Share & tools

Igor Zhbanov

author

2012-07-11 06:15 UTC #0 lore raw

Hello!

I have found that PowerTOP doesn't displays values in "GFX Wakeups/s" column. It is because of wrong event field name the handle_trace_point() method expects to find in a trace event.

Here is the patch:
--8<--Cut-here----------------------------------------------------------------

src/process/do_process.cpp +2 -2

diff -purN powertop/src/process/do_process.cpp powertop-new/src/process/do_process.cpp
@@ -340,7 +340,7 @@ void perf_process_bundle::handle_trace_p
  		int flags;
  		int pid;
 
-		ret = pevent_get_common_field_val(NULL, event, "flags",&rec,&val, 0);
+		ret = pevent_get_common_field_val(NULL, event, "common_flags",&rec,&val, 0);
  		if (ret<  0)
  			return;
  		flags = (int)val;

@@ -625,7 +625,7 @@ void perf_process_bundle::handle_trace_p
  		class power_consumer *consumer = NULL;
  		int flags;
 
-		ret = pevent_get_common_field_val(NULL, event, "flags",&rec,&val, 0);
+		ret = pevent_get_common_field_val(NULL, event, "common_flags",&rec,&val, 0);
  		if (ret<  0)
  			return;
  		flags = (int)val;

--8<--------------------------------------------------------------------------

Thank you.

Signature · 9 lines

Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com

ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation

src/process/do_process.cpp +2 -2

diff -purN powertop/src/process/do_process.cpp powertop-new/src/process/do_process.cpp
@@ -340,7 +340,7 @@ void perf_process_bundle::handle_trace_p
 		int flags;
 		int pid;
 
-		ret = pevent_get_common_field_val(NULL, event, "flags", &rec, &val, 0);
+		ret = pevent_get_common_field_val(NULL, event, "common_flags", &rec, &val, 0);
 		if (ret < 0)
 			return;
 		flags = (int)val;

@@ -625,7 +625,7 @@ void perf_process_bundle::handle_trace_p
 		class power_consumer *consumer = NULL;
 		int flags;
 
-		ret = pevent_get_common_field_val(NULL, event, "flags", &rec, &val, 0);
+		ret = pevent_get_common_field_val(NULL, event, "common_flags", &rec, &val, 0);
 		if (ret < 0)
 			return;
 		flags = (int)val;

Igor Zhbanov

author

2012-07-11 08:33 UTC #1 lore raw

Here is formatted version of the patch:

From 23362fa0f7bbfd0497a8ccbb9d06a4520eae8057 Mon Sep 17 00:00:00 2001
From: Igor Zhbanov<i.zhbanov(a)samsung.com>
Date: Wed, 11 Jul 2012 12:30:27 +0400
Subject: [PATCH] Wrong common field name in GFX Wakeups event

I have found that PowerTOP doesn't displays values in "GFX Wakeups/s" column. It is because of wrong event field name the handle_trace_point() method expects to find in a trace event.

---
  src/process/do_process.cpp |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

src/process/do_process.cpp +2 -2

index b7006ee..731fe3e 100644
@@ -312,7 +312,7 @@ void perf_process_bundle::handle_trace_point(void *trace, int cpu, uint64_t time
  		int flags;
  		int pid;
 
-		ret = pevent_get_common_field_val(NULL, event, "flags",&rec,&val, 0);
+		ret = pevent_get_common_field_val(NULL, event, "common_flags",&rec,&val, 0);
  		if (ret<  0)
  			return;
  		flags = (int)val;

@@ -597,7 +597,7 @@ void perf_process_bundle::handle_trace_point(void *trace, int cpu, uint64_t time
  		class power_consumer *consumer = NULL;
  		int flags;
 
-		ret = pevent_get_common_field_val(NULL, event, "flags",&rec,&val, 0);
+		ret = pevent_get_common_field_val(NULL, event, "common_flags",&rec,&val, 0);
  		if (ret<  0)
  			return;
  		flags = (int)val;

Signature · 1 line

1.7.5.4

Quoted 42 lines · Igor Zhbanov

Hello!
I have found that PowerTOP doesn't displays values in "GFX Wakeups/s" column.
It is because of wrong event field name the handle_trace_point() method expects to find in a trace event.
Here is the patch:
--8<--Cut-here----------------------------------------------------------------
diff -purN powertop/src/process/do_process.cpp
powertop-new/src/process/do_process.cpp
--- powertop/src/process/do_process.cpp 2012-07-05
13:06:16.080258858 +0400
+++ powertop-new/src/process/do_process.cpp 2012-07-06
13:31:14.382651388 +0400
(quoted diff) +1 -1
@@ -340,7 +340,7 @@ void perf_process_bundle::handle_trace_p
         int flags;
         int pid;
 
-        ret = pevent_get_common_field_val(NULL, event, 
 "flags",&rec,&val, 0);
+        ret = pevent_get_common_field_val(NULL, event, 
 "common_flags",&rec,&val, 0);
         if (ret<  0)
             return;
         flags = (int)val;
(quoted diff) +1 -1
@@ -625,7 +625,7 @@ void perf_process_bundle::handle_trace_p
         class power_consumer *consumer = NULL;
         int flags;
 
-        ret = pevent_get_common_field_val(NULL, event, 
 "flags",&rec,&val, 0);
+        ret = pevent_get_common_field_val(NULL, event, 
 "common_flags",&rec,&val, 0);
         if (ret<  0)
             return;
         flags = (int)val;
--8<--------------------------------------------------------------------------
Thank you.

Signature · 9 lines

Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com

ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation

Chris Ferron

2012-07-17 22:10 UTC #2 lore raw

In reply to Igor Zhbanov

Quoted 41 lines · Igor Zhbanov

Hello!
I have found that PowerTOP doesn't displays values in "GFX Wakeups/s" column.
It is because of wrong event field name the handle_trace_point() method expects to find in a trace event.
Here is the patch:
--8<--Cut-here----------------------------------------------------------------
diff -purN powertop/src/process/do_process.cpp
powertop-new/src/process/do_process.cpp
--- powertop/src/process/do_process.cpp 2012-07-05
13:06:16.080258858 +0400
+++ powertop-new/src/process/do_process.cpp 2012-07-06
13:31:14.382651388 +0400
src/process/do_process.cpp +1 -1
@@ -340,7 +340,7 @@ void perf_process_bundle::handle_trace_p
         int flags;
         int pid;
 
-        ret = pevent_get_common_field_val(NULL, event, 
 "flags",&rec,&val, 0);
+        ret = pevent_get_common_field_val(NULL, event, 
 "common_flags",&rec,&val, 0);
         if (ret<  0)
             return;
         flags = (int)val;
src/process/do_process.cpp +1 -1
@@ -625,7 +625,7 @@ void perf_process_bundle::handle_trace_p
         class power_consumer *consumer = NULL;
         int flags;
 
-        ret = pevent_get_common_field_val(NULL, event, 
 "flags",&rec,&val, 0);
+        ret = pevent_get_common_field_val(NULL, event, 
 "common_flags",&rec,&val, 0);
         if (ret<  0)
             return;
         flags = (int)val;
--8<--------------------------------------------------------------------------

Quoted 8 lines

Thank you.
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop

Your patch has been merged.
Thank you,