ALSA: hda - Add PCI quirk for 17" MacBook Pro 5, 2 model (July 2009) to use existing mb5 model
PATCH 1/1 ALSA: hda - Add PCI quirk for 17" MacBook Pro 5, 2 model (July 2009) to use existing mb5 model
From: Alex Murray <[email protected]>
--- pci/hda/patch_realtek.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
pci/hda/patch_realtek.c +1 -0
@@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {*/ SND_PCI_QUIRK (0x106b ,0x4000 ,"MacbookPro 5,1" ,ALC885_MB5 ),SND_PCI_QUIRK (0x106b ,0x4600 ,"MacbookPro 5,2" ,ALC885_MB5 ), + SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5), {} /* terminator */ };
Signature · 1 line
1.6.3.3
At Thu, 21 Jan 2010 22:16:26 +1030,
Quoted 14 lines · [email protected] wrote:
From: Alex Murray <[email protected]>
Signed-off-by Alex Murray <[email protected]>--- pci/hda/patch_realtek.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)pci/hda/patch_realtek.c +0
-0
pci/hda/patch_realtek.c static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = { · line 9226
Quoted 4 lines
pci/hda/patch_realtek.c +1
-0@@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {*/ SND_PCI_QUIRK (0x106b ,0x4000 ,"MacbookPro 5,1" ,ALC885_MB5 ),SND_PCI_QUIRK (0x106b ,0x4600 ,"MacbookPro 5,2" ,ALC885_MB5 ), + SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5),
Thanks for the patch.
But I wonder whether this entry is really correct. The value looks like the codec vendor id. There you need a PCI SSID. Did you confirm that your patch really works?
Takashi
Patch was supplied here:
https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/337314/comments/148
so no I can't personally confirm it works...
I agree it definitely looks odd - especially compared to the existing entries... okay I'll see if I can get some more info then and will repost if I can defintiely confirm it.
2010/1/21 Takashi Iwai <[email protected]>:
Quoted 29 lines
At Thu, 21 Jan 2010 22:16:26 +1030,
Quoted 14 lines · [email protected] wrote:
From: Alex Murray <[email protected]>
Signed-off-by Alex Murray <[email protected]>---
pci/hda/patch_realtek.c | 1 +1 files changed, 1 insertions(+), 0 deletions(-)pci/hda/patch_realtek.c +0
-0pci/hda/patch_realtek.c static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = { · line 9226
Quoted 4 lines
pci/hda/patch_realtek.c +1
-0@@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {*/ SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5), SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5), + SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5),Thanks for the patch.
But I wonder whether this entry is really correct. The value looks like the codec vendor id. There you need a PCI SSID. Did you confirm that your patch really works?Takashi
Indeed - turns out is was a config error, and the patch is invalid - thats a bit embarrassing - sorry for the noise. Thanks for looking at it nonetheless.
Cheers
2010/1/21 Alex Murray <[email protected]>:
Quoted 41 lines
Patch was supplied here:
https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/337314/comments/148
so no I can't personally confirm it works...I agree it definitely looks odd - especially compared to the existing entries... okay I'll see if I can get some more info then and will repost if I can defintiely confirm it.
2010/1/21 Takashi Iwai <[email protected]>:
Quoted 29 lines
At Thu, 21 Jan 2010 22:16:26 +1030,
Quoted 14 lines · [email protected] wrote:
From: Alex Murray <[email protected]>
Signed-off-by Alex Murray <[email protected]>---
pci/hda/patch_realtek.c | 1 +1 files changed, 1 insertions(+), 0 deletions(-)pci/hda/patch_realtek.c +0
-0pci/hda/patch_realtek.c static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = { · line 9226
Quoted 4 lines
pci/hda/patch_realtek.c +1
-0@@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {*/ SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5), SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5), + SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5),Thanks for the patch.
But I wonder whether this entry is really correct. The value looks like the codec vendor id. There you need a PCI SSID. Did you confirm that your patch really works?Takashi