Skip to contentSkip to conversation

perf_events: fix NULL point in free_event()

PATCH In review Stephane Eranian 2 participants 2 messages Sep 13, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf_events: fix NULL point in free_event()

Without the following patch, perf top as non-root and paranoid cpu set causes a NULL pointer dereference in free_event() because event->ctx is NULL.

free_event() may be called, on the error path, before event->ctx is set.

kernel/perf_event.c +2 -1
index f29b525..a7d5e7a 100644
@@ -2150,7 +2150,8 @@ static void free_event(struct perf_event *event)
 	if (event->destroy)
 		event->destroy(event);
 
-	put_ctx(event->ctx);
+	if (event->ctx)
+		put_ctx(event->ctx);
 	call_rcu(&event->rcu_head, free_event_rcu);
 }
 
#1 lore raw
Quoted 3 lines · Stephane Eranian

Without the following patch, perf top as non-root and paranoid cpu set causes a NULL pointer dereference in free_event() because event->ctx is NULL.

Yeah, its already on its way.. Cyrill also reported this.