Skip to contentSkip to conversation

batman-adv: Correct rcu refcounting for gw_node

PATCH jay.busch 1 participant 1 message Feb 2, 2011

lore
Share & tools
lore

jay.busch

author
#0 lore raw

Sent from my HTC PURE™, a Windows® phone from AT&T

-----Original Message-----
From: Marek Lindner <[email protected]>
Sent: Wednesday, February 02, 2011 2:49 PM
To: The list for a Better Approach To Mobile Ad-hoc Networking <[email protected]>
Subject: Re: [B.A.T.M.A.N.] [PATCH] Re: batman-adv: Correct rcu refcounting for gw_node

Quoted 7 lines · On Wednesday 02 February 2011 18:37:18 Linus Lüssing wrote:

So after some more discussions with Marek and Sven, it looks like we have to use the rcu protected macros rcu_dereference() and rcu_assign_pointer() for the bat_priv->curr_gw and curr_gw->orig_node.

Changes here also include moving the kref_get() from unicast_send_skb() into gw_get_selected(). The orig_node could have been freed already at the time the kref_get() was called in unicast_send_skb().

I'd suggest you make a standalone patch because the patches address different problems.

Thanks,
Marek