Skip to contentSkip to conversation

ehci_hcd: inclusion of multiple platform drivers

Question [email protected] 3 participants 3 messages Jun 17, 2011 1 message not in the archive Arm Qualcomm mailing list

lore
Share & tools
lore
#0 lore raw

Hi,

I am working on an SOC where requirement is to include more than one host controller platform driver from ehci_hcd.c.
Since, the current framework supports inclusion of just one platform driver, I was wondering if we can have some generic solution similar to below in ehci_hcd.c:

#ifdef CONFIG_USB_EHCI_FSL
#include "ehci-fsl.c"
#endif

#ifdef CONFIG_USB_EHCI_MXC
#include "ehci-mxc.c"
#endif

<...snip....>

static struct platform_driver *plat_drivers[] = { #ifdef CONFIG_USB_EHCI_FSL &ehci_fsl_driver, #endif

#ifdef CONFIG_USB_EHCI_MXC
&ehci_mxc_driver,
#endif

.....
}

And we can register all the drivers entries in a for loop from ehci_hcd_init.

Kindly let me know if this approach looks fine. I shall then submit a patch. I am sorry for not placing the actual patch in this mail for review.

Thanks,
Manu

A message that is not in the archive (sent off-list or not yet received): 4d6bde24de4d4824d89438ebe97c6e6c.squirrel-mMfbam+mt9083fI46fginR2eb7JE58TQ@public.gmane.org

#2 lore raw

Including linux-usb.

Quoted 34 lines · On 6/17/2011 6:18 PM, [email protected] wrote:

Hi,

I am working on an SOC where requirement is to include more than one host controller platform driver from ehci_hcd.c.
Since, the current framework supports inclusion of just one platform driver, I was wondering if we can have some generic solution similar to below in ehci_hcd.c:

#ifdef CONFIG_USB_EHCI_FSL
#include "ehci-fsl.c"
#endif

#ifdef CONFIG_USB_EHCI_MXC
#include "ehci-mxc.c"
#endif

<...snip....>

static struct platform_driver *plat_drivers[] = { #ifdef CONFIG_USB_EHCI_FSL&ehci_fsl_driver, #endif

#ifdef CONFIG_USB_EHCI_MXC
&ehci_mxc_driver,
#endif

.....
}

And we can register all the drivers entries in a for loop from ehci_hcd_init.

Kindly let me know if this approach looks fine. I shall then submit a patch. I am sorry for not placing the actual patch in this mail for review.

Quoted 8 lines

Thanks,
Manu

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 10 lines · * Anirudh Ghayal | 2011-06-17 18:26:24 [+0530]:

Including linux-usb.

Quoted 7 lines · On 6/17/2011 6:18 PM, [email protected] wrote:

Hi,

I am working on an SOC where requirement is to include more than one host controller platform driver from ehci_hcd.c.
Since, the current framework supports inclusion of just one platform driver, I was wondering if we can have some generic solution similar to below in ehci_hcd.c:

Take a look at the "usb: host: xhci: give xhci a platform_device" thread where Felipe suggest a platform device for xhci [0]. Maybe something similar should be done [eou]hci as well. Simply add one device with proper ressources.

[0] http://article.gmane.org/gmane.linux.usb.general/48028

Sebastian