Skip to contentSkip to conversation

iio: adc: ad7192: fix null de-ref crash during probe

PATCH Markus Elfring 2 participants 2 messages Apr 6, 2020 – Apr 7, 2020 IIO

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes during probe with null de-ref.

How do you think about to use the term “null pointer dereference” in the commit message?

Quoted 1 line

Fixes 66614ab2be38: ("staging: iio: adc: ad7192: removed spi_device_id")

Please correct this tag.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2#n183

Why was a colon misplaced here?

Regards,
Markus

#1 lore raw
Quoted 5 lines · Markus Elfring
Quoted 2 lines

After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes during probe with null de-ref.

How do you think about to use the term “null pointer dereference” in the commit message?

depends how long the commit title with be
will take a look

Quoted 8 lines
Quoted 3 lines

Fixes 66614ab2be38: ("staging: iio: adc: ad7192: removed spi_device_id")

Please correct this tag.
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2*n183__;Iw!!A3Ni8CS0y2Y!uk9bOaD_449N0PxwtQ_WikWYY5KnpykeZTp-rbrRTju7FZM6fPd48zCD1pe7rTSYypKYkg$

Why was a colon misplaced here?

will fix
thanks

Quoted 3 lines

Regards,
Markus