Skip to contentSkip to conversation

xfs: Remove type argument from xfs_seek_data() and xfs_seek_hole().

PATCH Superseded Jeff Liu 2 participants 3 messages Jul 26, 2012 – Jul 27, 2012 XFS filesystem

v5 of 8 Superseded Latest is v8 →

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH v5 1/4 xfs: Remove type argument from xfs_seek_data() and xfs_seek_hole().

The type is already indicated by the function naming explicitly, so this argument can be omitted from those calls.

Signed-off-by Jie Liu <[email protected]>
Reviewed-by Mark Tinguely <[email protected]>
Reviewed-by Christoph Hellwig <[email protected]>
Reviewed-by Dave Chinner <[email protected]>
---
 fs/xfs/xfs_file.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
fs/xfs/xfs_file.c +4 -6
index 9f7ec15..98642cf 100644
@@ -969,8 +969,7 @@ xfs_vm_page_mkwrite(
 STATIC loff_t
 xfs_seek_data(
 	struct file		*file,
-	loff_t			start,
-	u32			type)
+	loff_t			start)
 {
 	struct inode		*inode = file->f_mapping->host;
 	struct xfs_inode	*ip = XFS_I(inode);

@@ -1036,8 +1035,7 @@ out_unlock:
 STATIC loff_t
 xfs_seek_hole(
 	struct file		*file,
-	loff_t			start,
-	u32			type)
+	loff_t			start)
 {
 	struct inode		*inode = file->f_mapping->host;
 	struct xfs_inode	*ip = XFS_I(inode);

@@ -1099,9 +1097,9 @@ xfs_file_llseek(
 	case SEEK_SET:
 		return generic_file_llseek(file, offset, origin);
 	case SEEK_DATA:
-		return xfs_seek_data(file, offset, origin);
+		return xfs_seek_data(file, offset);
 	case SEEK_HOLE:
-		return xfs_seek_hole(file, offset, origin);
+		return xfs_seek_hole(file, offset);
 	default:
 		return -EINVAL;
 	}
Signature · 6 lines
1.7.4.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
author
#1 lore raw

PATCH v5 1/4 xfs: Remove type argument from xfs_seek_data() and xfs_seek_hole().

The type is already indicated by the function naming explicitly, so this argument can be omitted from those calls.

Signed-off-by Jie Liu <[email protected]>
Reviewed-by Mark Tinguely <[email protected]>
Reviewed-by Christoph Hellwig <[email protected]>
Reviewed-by Dave Chinner <[email protected]>
---
 fs/xfs/xfs_file.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
fs/xfs/xfs_file.c +4 -6
index 9f7ec15..98642cf 100644
@@ -969,8 +969,7 @@ xfs_vm_page_mkwrite(
 STATIC loff_t
 xfs_seek_data(
 	struct file		*file,
-	loff_t			start,
-	u32			type)
+	loff_t			start)
 {
 	struct inode		*inode = file->f_mapping->host;
 	struct xfs_inode	*ip = XFS_I(inode);

@@ -1036,8 +1035,7 @@ out_unlock:
 STATIC loff_t
 xfs_seek_hole(
 	struct file		*file,
-	loff_t			start,
-	u32			type)
+	loff_t			start)
 {
 	struct inode		*inode = file->f_mapping->host;
 	struct xfs_inode	*ip = XFS_I(inode);

@@ -1099,9 +1097,9 @@ xfs_file_llseek(
 	case SEEK_SET:
 		return generic_file_llseek(file, offset, origin);
 	case SEEK_DATA:
-		return xfs_seek_data(file, offset, origin);
+		return xfs_seek_data(file, offset);
 	case SEEK_HOLE:
-		return xfs_seek_hole(file, offset, origin);
+		return xfs_seek_hole(file, offset);
 	default:
 		return -EINVAL;
 	}
Signature · 6 lines
1.7.4.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs