yasm: New package
PATCH 1/1 yasm: New package
My first git format patch.
This is needed by Firefox WebM support. Firefox is almost ready too but need few changes to cairo and libpng.
Hopefully it went right (can somebody suggest some good, git online tutorial or book?).
Stefan
--- package/Config.in | 1 + package/yasm/Config.in | 9 +++++++++ package/yasm/yasm.mk | 23 +++++++++++++++++++++++ 3 files changed, 33 insertions(+), 0 deletions(-) create mode 100644 package/yasm/Config.in create mode 100644 package/yasm/yasm.mk
package/Config.in +1 -0
@@ -91,6 +91,7 @@ source "package/sstrip/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/tar/Config.in" endif +source "package/yasm/Config.in" endmenu menu "Games"
package/yasm/Config.in new file +9 -0
@@ -0,0 +1,9 @@ +config BR2_PACKAGE_YASM + bool "yasm" + help + Yasm is a complete rewrite of the NASM-2.10.01 assembler. + It supports the x86 and AMD64 instruction sets, accepts NASM + and GAS assembler syntaxes and outputs binary, ELF32 and ELF64 + object formats. + +
package/yasm/yasm.mk new file +23 -0
@@ -0,0 +1,23 @@ +############################################################# +# +# yasm +# +############################################################# +YASM_VERSION = 1.2.0 +YASM_SOURCE = yasm-$(YASM_VERSION).tar.gz +YASM_SITE = http://www.tortall.net/projects/yasm/releases/ +YASM_CONF_OPT = --enable-shared + +define YASM_PRE_CONFIGURE_FIXUP +# This sed prevents it compiling 2 programs (vsyasm and ytasm) +# that are only of use on Microsoft Windows. +# cd $(@D) + sed -i 's#) ytasm.*#)#' $(@D)/Makefile.in +endef + +YASM_PRE_CONFIGURE_HOOKS += YASM_PRE_CONFIGURE_FIXUP + + + +$(eval $(call AUTOTARGETS)) +$(eval $(call AUTOTARGETS,host))
Signature · 1 line
1.7.7.6
PATCH 1/1 yasm: New package
Hello Stefan,
Thanks for this contribution!
Le Wed, 08 Aug 2012 23:26:11 +0300,
Stefan Fr?berg <[email protected]> a ?crit :
Quoted 10 lines
My first git format patch.
This is needed by Firefox WebM support. Firefox is almost ready too but need few changes to cairo and libpng.Hopefully it went right (can somebody suggest some good, git online tutorial or book?).
Stefan
Signed-off-by Stefan Froberg <[email protected]>
You shouldn't include "personal" messages in the commit log here. This part of the commit log will remain forever in the Git history, so we don't want to have messages like "Hopefully it went right...".
If you have something to say beyond the commit log itself, then I think the easiest solution is to use git send-email --compose, which will prompt you for the text of an introduction e-mail. Then git send-email will send N+1 e-mails: your introduction e-mail + the N patches you told send-email to send. And git send-email is smart enough to make those N emails replies to the introduction e-mail.
Quoted 26 lines
--- package/Config.in | 1 + package/yasm/Config.in | 9 +++++++++ package/yasm/yasm.mk | 23 +++++++++++++++++++++++ 3 files changed, 33 insertions(+), 0 deletions(-) create mode 100644 package/yasm/Config.in create mode 100644 package/yasm/yasm.mkpackage/Config.in +1
-0@@ -91,6 +91,7 @@ source "package/sstrip/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/tar/Config.in" endif +source "package/yasm/Config.in" endmenu menu "Games"package/yasm/Config.in new file +0
-0
package/yasm/Config.in line 2
Quoted 2 lines
package/yasm/Config.in new file +2
-0@@ -0,0 +1,9 @@ +config BR2_PACKAGE_YASM + bool "yasm"
depends on BR2_i386 || BR2_x86_64
package/yasm/Config.in line 9
Quoted 7 lines
package/yasm/Config.in new file +7
-0+ help + Yasm is a complete rewrite of the NASM-2.10.01 assembler. + It supports the x86 and AMD64 instruction sets, accepts NASM + and GAS assembler syntaxes and outputs binary, ELF32 and ELF64 + object formats. + +
Remove one newline here.
Quoted 6 lines
package/yasm/yasm.mk new file +0
-0
package/yasm/yasm.mk line 9
Quoted 9 lines
package/yasm/yasm.mk new file +9
-0@@ -0,0 +1,23 @@ +############################################################# +# +# yasm +# +############################################################# +YASM_VERSION = 1.2.0 +YASM_SOURCE = yasm-$(YASM_VERSION).tar.gz +YASM_SITE = http://www.tortall.net/projects/yasm/releases/ +YASM_CONF_OPT = --enable-shared
This is useless, --enable-shared is passed by default.
package/yasm/yasm.mk line 14
Quoted 5 lines
package/yasm/yasm.mk new file +5
-0+ +define YASM_PRE_CONFIGURE_FIXUP +# This sed prevents it compiling 2 programs (vsyasm and ytasm) +# that are only of use on Microsoft Windows. +# cd $(@D)
Remove this last line of comment.
package/yasm/yasm.mk line 21
Quoted 7 lines
package/yasm/yasm.mk new file +7
-0+ sed -i 's#) ytasm.*#)#' $(@D)/Makefile.in +endef + +YASM_PRE_CONFIGURE_HOOKS += YASM_PRE_CONFIGURE_FIXUP + + +
Make this only one empty new line.
package/yasm/yasm.mk line 23
Quoted 2 lines
package/yasm/yasm.mk new file +2
-0+$(eval $(call AUTOTARGETS)) +$(eval $(call AUTOTARGETS,host))
And this should now be:
$(eval $(autotools-package))
$(eval $(host-autotools-package))
(It has changed between 2012.05 and the current Git version).
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 yasm: New package
Quoted 10 lines · Thomas Petazzoni
You shouldn't include "personal" messages in the commit log here. This part of the commit log will remain forever in the Git history, so we don't want to have messages like "Hopefully it went right...".
If you have something to say beyond the commit log itself, then I think the easiest solution is to use git send-email --compose, which will prompt you for the text of an introduction e-mail. Then git send-email will send N+1 e-mails: your introduction e-mail + the N patches you told send-email to send. And git send-email is smart enough to make those N emails replies to the introduction e-mail.
Alternatively you can put text that won't be included in the commit log after the first --- and before the diffstat, which seems more appropriate for a standalone patch.
Alex