Skip to contentSkip to conversation

setns vs unshare bug

DISCUSSION Pavel Emelyanov 2 participants 5 messages Aug 10, 2012 3 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Hi, Eric!

There's an issue with setns versus unshare syscall which I consider to be worth looking at. Look -- when you open some task's namespace file, e.g. /proc/<pid>/ns/net, the net namespace is cached on the proc inode.

If later the task with the pid <pid> unshares the namespace in question (in this case -- net ns) the subsequent openings of this task's proc ns file will result in old namespace obtained and the setns call will not work as expected. Here's a simple proggie which demonstrates this:

int main(void)

{
	int pid, fd;
	char path[64];

	pid = fork();
	if (!pid) {
		fd = open("/proc/self/ns/net", O_RDONLY);
		close(fd);
		unshare(CLONE_NEWNET);
		printf("New net:\n");
		system("ip l");
		sleep(1);
	} else {
		sleep(1);
		printf("Old net:\n");
		system("ip l");
		sprintf(path, "/proc/%d/ns/net", pid);
		fd = open(path, O_RDONLY);
		set_ns(fd, CLONE_NEWNET);
		printf("New net 2:\n");
		system("ip l");
	}

	return 0;
}

The "else" branch after set_ns expects the net it set to be the new one (and contain a lo device only), but it's not so -- after the setns syscall the net namespace isn't changed! If you comment out the "if" branch's open and close calls (thus avoiding the ns caching) the setns works as expected.

I assume you're aware of this problem, so do you have plans to fix this?

Thanks,
Pavel

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi Pavel,

I don't believe this is a bug. The fd is to a specific network namespace. If the target task later changes his namespace, that doesn't change the fact that you asked for access to the old namespace.

You're worried about a race?

-serge

Quoted 51 lines · Pavel Emelyanov

Hi, Eric!

There's an issue with setns versus unshare syscall which I consider to be worth looking at. Look -- when you open some task's namespace file, e.g. /proc/<pid>/ns/net, the net namespace is cached on the proc inode.

If later the task with the pid <pid> unshares the namespace in question (in this case -- net ns) the subsequent openings of this task's proc ns file will result in old namespace obtained and the setns call will not work as expected. Here's a simple proggie which demonstrates this:

int main(void)

{
	int pid, fd;
	char path[64];

	pid = fork();
	if (!pid) {
		fd = open("/proc/self/ns/net", O_RDONLY);
		close(fd);
		unshare(CLONE_NEWNET);
		printf("New net:\n");
		system("ip l");
		sleep(1);
	} else {
		sleep(1);
		printf("Old net:\n");
		system("ip l");
		sprintf(path, "/proc/%d/ns/net", pid);
		fd = open(path, O_RDONLY);
		set_ns(fd, CLONE_NEWNET);
		printf("New net 2:\n");
		system("ip l");
	}

	return 0;
}

The "else" branch after set_ns expects the net it set to be the new one (and contain a lo device only), but it's not so -- after the setns syscall the net namespace isn't changed! If you comment out the "if" branch's open and close calls (thus avoiding the ns caching) the setns works as expected.

I assume you're aware of this problem, so do you have plans to fix this?

Thanks,
Pavel
_______________________________________________
Containers mailing list Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/containers

#3 lore raw
Quoted 8 lines · Serge Hallyn

Hi Pavel,

I don't believe this is a bug. The fd is to a specific network namespace. If the target task later changes his namespace, that doesn't change the fact that you asked for access to the old namespace.

You're worried about a race?

No, it's not a race. The proc ns file doesn't reflect the actual state of a task it belongs to, but instead has some internal state which is not observable/controllable from the outside. Look at my proggie -- the "else" branch does expects that setns will bring it into a new net, but it only does so if proc dcache is empty!

Thanks,
Pavel

Quoted 56 lines

-serge

Quoted 43 lines · Pavel Emelyanov

Hi, Eric!

There's an issue with setns versus unshare syscall which I consider to be worth looking at. Look -- when you open some task's namespace file, e.g. /proc/<pid>/ns/net, the net namespace is cached on the proc inode.

If later the task with the pid <pid> unshares the namespace in question (in this case -- net ns) the subsequent openings of this task's proc ns file will result in old namespace obtained and the setns call will not work as expected. Here's a simple proggie which demonstrates this:

int main(void)

{
	int pid, fd;
	char path[64];

	pid = fork();
	if (!pid) {
		fd = open("/proc/self/ns/net", O_RDONLY);
		close(fd);
		unshare(CLONE_NEWNET);
		printf("New net:\n");
		system("ip l");
		sleep(1);
	} else {
		sleep(1);
		printf("Old net:\n");
		system("ip l");
		sprintf(path, "/proc/%d/ns/net", pid);
		fd = open(path, O_RDONLY);
		set_ns(fd, CLONE_NEWNET);
		printf("New net 2:\n");
		system("ip l");
	}

	return 0;
}

The "else" branch after set_ns expects the net it set to be the new one (and contain a lo device only), but it's not so -- after the setns syscall the net namespace isn't changed! If you comment out the "if" branch's open and close calls (thus avoiding the ns caching) the setns works as expected.

Quoted 8 lines

I assume you're aware of this problem, so do you have plans to fix this?

Thanks,
Pavel
_______________________________________________
Containers mailing list Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/containers

.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 8 lines · Pavel Emelyanov
Quoted 7 lines · Serge Hallyn

Hi Pavel,

I don't believe this is a bug. The fd is to a specific network namespace. If the target task later changes his namespace, that doesn't change the fact that you asked for access to the old namespace.

Quoted 7 lines
Quoted 1 line

You're worried about a race?

No, it's not a race. The proc ns file doesn't reflect the actual state of a task it belongs to, but instead has some internal state which is not observable/controllable from the outside. Look at my proggie -- the "else" branch does expects that setns will bring it into a new net, but it only does so if proc dcache is empty!

I mean -- I open a task's proc ns file _strictly_ _after_ that task called unshare, but happen to obtain an _old_ net namespace, because this old netns was cached on the task's proc file.

Hope this explains better what I'm concerned about.

Thanks,
Pavel

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw
Quoted 17 lines · Pavel Emelyanov
Quoted 8 lines · Pavel Emelyanov
Quoted 7 lines · Serge Hallyn

Hi Pavel,

I don't believe this is a bug. The fd is to a specific network namespace. If the target task later changes his namespace, that doesn't change the fact that you asked for access to the old namespace.

Quoted 7 lines
Quoted 1 line

You're worried about a race?

No, it's not a race. The proc ns file doesn't reflect the actual state of a task it belongs to, but instead has some internal state which is not observable/controllable from the outside. Look at my proggie -- the "else" branch does expects that setns will bring it into a new net, but it only does so if proc dcache is empty!

Quoted 5 lines

I mean -- I open a task's proc ns file _strictly_ _after_ that task called unshare, but happen to obtain an _old_ net namespace, because this old netns was cached on the task's proc file.

Hope this explains better what I'm concerned about.

Ooh! Sorry, now I see.

-serge