video/udlfb: fix line counting in fb_write
PATCH RESEND 1/1 video/udlfb: fix line counting in fb_write
Line 0 and 1 were both written to line 0 (on the display) and all subsequent lines had an offset of -1. The result was that the last line on the display was never overwritten by writes to /dev/fbN.
--- drivers/video/udlfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/udlfb.c +0 -0
@@ -647,7 +647,7 @@ static ssize_t dlfb_ops_write(struct fb_info *info,
const char __user *buf,
result = fb_sys_write(info, buf, count, ppos);
if (result > 0) {
- int start = max((int)(offset / info->fix.line_length) - 1, 0);
+ int start = max((int)(offset / info->fix.line_length), 0);
int lines = min((u32)((result / info->fix.line_length) + 1),
(u32)info->var.yres);
-- 1.7.6.5
Quoted 7 lines · Alexander Holler
Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display was never overwritten by writes to/dev/fbN.Signed-off-by Alexander Holler <[email protected]>
As Bernie agreed but didn't send me a pull request, I applied this one. Though the formatting was screwed up and I had to fix it...
Best regards,
Florian Tobias Schandinat
Quoted 23 lines
--- drivers/video/udlfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/video/udlfb.c +1
-1@@ -647,7 +647,7 @@ static ssize_t dlfb_ops_write(struct fb_info *info,const char __user *buf, result =fb_sys_write (info, buf, count, ppos);if (result >0 ) { -int start =max ((int )(offset / info->fix.line_length) -1 ,0 ); +int start =max ((int )(offset / info->fix.line_length),0 );int lines =min ((u32)((result / info->fix.line_length) +1 ), (u32 )info->var.yres); -- 1.7.6.5Signature · 4 lines
-- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 10.10.2012 14:29, schrieb Florian Tobias Schandinat:
Quoted 10 lines · Alexander Holler
Quoted 7 lines
Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display was never overwritten by writes to/dev/fbN.Signed-off-by Alexander Holler <[email protected]>As Bernie agreed but didn't send me a pull request, I applied this one.
Thanks a lot.
Quoted 1 line
Though the formatting was screwed up and I had to fix it...
Sorry, must have happened because I've used "Edit as new" in Thunderbird to resend the patch while just adding the RESEND to the subject.
Good to know.
Thanks,
Alexander