audio: Make pcspk card selectable again

PATCH RESEND Applied Jan Kiszka 2 participants 2 messages Aug 16, 2012

Share & tools

Jan Kiszka

author

2012-08-16 09:01 UTC #0 lore raw

PATCH RESEND 1/1 audio: Make pcspk card selectable again

Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per target. Therefore, statically built soundhw array in arch_init.c stopped including this card.

Work around this by re-adding this define to config-target.mak. Long-term, a dynamic creation of this soundhw list will be necessary.

Signed-off-by Jan Kiszka <[email protected]>

---
 configure |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

configure +5 -0

index be292fe..672da59 100755
@@ -3902,6 +3902,11 @@ if test "$target_bsd_user" = "yes" ; then
   echo "CONFIG_BSD_USER=y" >> $config_target_mak
 fi
 
+# the static way of configuring available audio cards requires this workaround
+if test "$target_user_only" != "yes" && grep -q CONFIG_PCSPK $source_path/default-configs/$target.mak; then
+  echo "CONFIG_PCSPK=y" >> $config_target_mak
+fi
+
 # generate QEMU_CFLAGS/LDFLAGS for targets
 
 cflags=""

Signature · 1 line

1.7.3.4

malc

Applied

2012-08-16 14:54 UTC #1 lore raw

Quoted 7 lines · Jan Kiszka

Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per target. Therefore, statically built soundhw array in arch_init.c stopped including this card.
Work around this by re-adding this define to config-target.mak. Long-term, a dynamic creation of this soundhw list will be necessary.

Thanks, applied.

[..snip..]

Signature · 1 line

mailto:[email protected]