Skip to contentSkip to conversation

Fix the qla2xxx loopback selftests

PATCH In review [email protected] 4 participants 4 messages Aug 14, 2012 – Oct 22, 2012 SCSI

lore
Share & tools
lore
#0 lore raw

cover Fix the qla2xxx loopback selftests

From: Steve Hodgson <[email protected]>

A few months ago our 2.6.39 based kernel started crashing almost 100% of the time when running the selftests, after seeminly unrelated kernel changes. In the end it was traced down to this use after free.

Whilst here fix an error path memory leak.

Thanks,

Steve

Steve Hodgson (2):
qla2xxx: Fix use after free in qla2x000_process_loopback.
qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()

 drivers/scsi/qla2xxx/qla_bsg.c |   17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 10 lines · On Tue, 14 Aug 2012, [email protected] wrote:

From: Steve Hodgson <[email protected]>

A few months ago our 2.6.39 based kernel started crashing almost 100% of the time when running the selftests, after seeminly unrelated kernel changes. In the end it was traced down to this use after free.

Whilst here fix an error path memory leak.

Thanks,

Quoted 10 lines

Steve

Steve Hodgson (2):
qla2xxx: Fix use after free in qla2x000_process_loopback.
qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()

drivers/scsi/qla2xxx/qla_bsg.c | 17 +++++++++--------

1 file changed, 9 insertions(+), 8 deletions(-)

Hi Steve, thanks for the patches. We'll look into them and let you know if there is anything extra needed.

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

#2 lore raw
Quoted 20 lines · Chad Dupuis
Quoted 16 lines · On Tue, 14 Aug 2012, [email protected] wrote:

From: Steve Hodgson <[email protected]>

A few months ago our 2.6.39 based kernel started crashing almost 100% of the time when running the selftests, after seeminly unrelated kernel changes. In the end it was traced down to this use after free.

Whilst here fix an error path memory leak.

Thanks,

Steve

Steve Hodgson (2):
qla2xxx: Fix use after free in qla2x000_process_loopback.
qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()

Quoted 7 lines
Quoted 4 lines

drivers/scsi/qla2xxx/qla_bsg.c | 17 +++++++++--------

1 file changed, 9 insertions(+), 8 deletions(-)

Hi Steve, thanks for the patches. We'll look into them and let you know if there is anything extra needed.

Looking at the 3.7-rc code, it looks like the use-after-free is still there. Any plans on merging these patches?

- R.

#3 lore raw
Quoted 30 lines
Quoted 25 lines · Chad Dupuis
Quoted 20 lines · On Tue, 14 Aug 2012, [email protected] wrote:

From: Steve Hodgson <[email protected]>

A few months ago our 2.6.39 based kernel started crashing almost 100% of the time when running the selftests, after seeminly unrelated kernel changes. In the end it was traced down to this use after free.

Whilst here fix an error path memory leak.

Thanks,

Steve

Steve Hodgson (2):
qla2xxx: Fix use after free in qla2x000_process_loopback.
qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()

drivers/scsi/qla2xxx/qla_bsg.c | 17 +++++++++--------

1 file changed, 9 insertions(+), 8 deletions(-)
Quoted 7 lines
Quoted 3 lines

Hi Steve, thanks for the patches. We'll look into them and let you know if
there is anything extra needed.

Looking at the 3.7-rc code, it looks like the use-after-free is still there.
Any plans on merging these patches?

Hi Roland,
The above changes are applicable to other bsg calls also, the changes are under test and will be submitted in the next submission.

Thanks,
~Saurav

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.