Skip to contentSkip to conversation

mmc: dw-mmc: add the platdata related with clock

PATCH Superseded Jaehoon Chung 3 participants 5 messages Aug 23, 2012 – Aug 24, 2012

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jaehoon Chung

author maintainer
#0 lore raw

PATCH 3/5 mmc: dw-mmc: add the platdata related with clock

Some SoC need to set the clock-phase shift.
So Add the callback function into platdata for using phase-shift

---
 drivers/mmc/host/dw_mmc.c  |    3 +++
 include/linux/mmc/dw_mmc.h |    8 ++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)
drivers/mmc/host/dw_mmc.c +3 -0
index 8bef3c2..feafa2d 100644
@@ -824,6 +824,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 
 	mci_writel(slot->host, UHS_REG, regs);
 
+	if (slot->host->pdata->set_clk_drv_sample)
+		slot->host->pdata->set_clk_drv_sample(slot->host, ios);
+
 	if (ios->clock) {
 		/*
 		 * Use mirror of ios->clock to prevent race with mmc
include/linux/mmc/dw_mmc.h +8 -0
index 7a7ebd3..f20979c 100644
@@ -229,6 +229,9 @@ struct dw_mci_board {
 	 */
 	unsigned int fifo_depth;
 
+	u32 ddr_timing;		/* DDR clock phase timing value */
+	u32 sdr_timing;		/* SDR clock phase timing value */
+
 	/* delay in mS before detecting cards after interrupt */
 	u32 detect_delay_ms;
 
@@ -249,6 +252,11 @@ struct dw_mci_board {
 	struct dw_mci_dma_ops *dma_ops;
 	struct dma_pdata *data;
 	struct block_settings *blk_settings;
+
+	int (*get_clk_drv)(struct dw_mci *);
+	int (*get_clk_sample)(struct dw_mci *);
+	void (*set_clk_drv_sample)(struct dw_mci *host, struct mmc_ios *ios);
+
 };
 
 #endif /* LINUX_MMC_DW_MMC_H */
Signature · 1 line
1.7.4.1
#1 lore raw

On Thu, Aug 23, 2012 at 12:31 PM, Jaehoon Chung <[email protected]> wrote:

Hi Jaehoon,

Quoted 29 lines

Some SoC need to set the clock-phase shift.
So Add the callback function into platdata for using phase-shift

---
 drivers/mmc/host/dw_mmc.c  |    3 +++
 include/linux/mmc/dw_mmc.h |    8 ++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)
drivers/mmc/host/dw_mmc.c +3 -0
index 8bef3c2..feafa2d 100644
@@ -824,6 +824,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 
        mci_writel(slot->host, UHS_REG, regs);
 
+       if (slot->host->pdata->set_clk_drv_sample)
+               slot->host->pdata->set_clk_drv_sample(slot->host, ios);
+
        if (ios->clock) {
                /*
                 * Use mirror of ios->clock to prevent race with mmc
include/linux/mmc/dw_mmc.h +0 -0
index 7a7ebd3..f20979c 100644

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 234

Quoted 6 lines
include/linux/mmc/dw_mmc.h +3 -0
@@ -229,6 +229,9 @@ struct dw_mci_board {
         */
        unsigned int fifo_depth;
 
+       u32 ddr_timing;         /* DDR clock phase timing value */
+       u32 sdr_timing;         /* SDR clock phase timing value */
+

These members...

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 257

Quoted 10 lines
include/linux/mmc/dw_mmc.h +3 -0
        /* delay in mS before detecting cards after interrupt */
        u32 detect_delay_ms;
 
@@ -249,6 +252,11 @@ struct dw_mci_board {
        struct dw_mci_dma_ops *dma_ops;
        struct dma_pdata *data;
        struct block_settings *blk_settings;
+
+       int (*get_clk_drv)(struct dw_mci *);
+       int (*get_clk_sample)(struct dw_mci *);

...and these members do not seem to be used in the rest of this patch. Should they be included?

Quoted 11 lines
include/linux/mmc/dw_mmc.h +2 -1
+       void (*set_clk_drv_sample)(struct dw_mci *host, struct mmc_ios *ios);
+
 };
 
 #endif /* LINUX_MMC_DW_MMC_H */
--

1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#2 lore raw

Hi Will,

Quoted 45 lines · Will Newton

On Thu, Aug 23, 2012 at 12:31 PM, Jaehoon Chung <[email protected]> wrote:

Hi Jaehoon,

Quoted 29 lines

Some SoC need to set the clock-phase shift.
So Add the callback function into platdata for using phase-shift

---
 drivers/mmc/host/dw_mmc.c  |    3 +++
 include/linux/mmc/dw_mmc.h |    8 ++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)
drivers/mmc/host/dw_mmc.c +3 -0
index 8bef3c2..feafa2d 100644
@@ -824,6 +824,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 
        mci_writel(slot->host, UHS_REG, regs);
 
+       if (slot->host->pdata->set_clk_drv_sample)
+               slot->host->pdata->set_clk_drv_sample(slot->host, ios);
+
        if (ios->clock) {
                /*
                 * Use mirror of ios->clock to prevent race with mmc
include/linux/mmc/dw_mmc.h +0 -0
index 7a7ebd3..f20979c 100644

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 234

Quoted 6 lines
include/linux/mmc/dw_mmc.h +3 -0
@@ -229,6 +229,9 @@ struct dw_mci_board {
         */
        unsigned int fifo_depth;
 
+       u32 ddr_timing;         /* DDR clock phase timing value */
+       u32 sdr_timing;         /* SDR clock phase timing value */
+

These members...

Quoted 3 lines
include/linux/mmc/dw_mmc.h +0 -0
        /* delay in mS before detecting cards after interrupt */
        u32 detect_delay_ms;
 
Quoted 10 lines

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 257

Quoted 7 lines
include/linux/mmc/dw_mmc.h +3 -0
@@ -249,6 +252,11 @@ struct dw_mci_board {
        struct dw_mci_dma_ops *dma_ops;
        struct dma_pdata *data;
        struct block_settings *blk_settings;
+
+       int (*get_clk_drv)(struct dw_mci *);
+       int (*get_clk_sample)(struct dw_mci *);

...and these members do not seem to be used in the rest of this patch. Should they be included?

These member should be used at exynos-soc.
I will also send the patch related with them.

Thanks for comments.

Best Regards,
Jaehoon Chung

Quoted 17 lines
Quoted 7 lines
include/linux/mmc/dw_mmc.h +2 -1
+       void (*set_clk_drv_sample)(struct dw_mci *host, struct mmc_ios *ios);
+
 };
 
 #endif /* LINUX_MMC_DW_MMC_H */
--
Quoted 5 lines

1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 58 lines · Jaehoon Chung

Hi Will,

Quoted 45 lines · Will Newton

On Thu, Aug 23, 2012 at 12:31 PM, Jaehoon Chung <[email protected]> wrote:

Hi Jaehoon,

Quoted 29 lines

Some SoC need to set the clock-phase shift.
So Add the callback function into platdata for using phase-shift

---
 drivers/mmc/host/dw_mmc.c  |    3 +++
 include/linux/mmc/dw_mmc.h |    8 ++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)
drivers/mmc/host/dw_mmc.c +3 -0
index 8bef3c2..feafa2d 100644
@@ -824,6 +824,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 
        mci_writel(slot->host, UHS_REG, regs);
 
+       if (slot->host->pdata->set_clk_drv_sample)
+               slot->host->pdata->set_clk_drv_sample(slot->host, ios);
+
        if (ios->clock) {
                /*
                 * Use mirror of ios->clock to prevent race with mmc
include/linux/mmc/dw_mmc.h +0 -0
index 7a7ebd3..f20979c 100644

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 234

Quoted 6 lines
include/linux/mmc/dw_mmc.h +3 -0
@@ -229,6 +229,9 @@ struct dw_mci_board {
         */
        unsigned int fifo_depth;
 
+       u32 ddr_timing;         /* DDR clock phase timing value */
+       u32 sdr_timing;         /* SDR clock phase timing value */
+

These members...

Quoted 3 lines
include/linux/mmc/dw_mmc.h +0 -0
        /* delay in mS before detecting cards after interrupt */
        u32 detect_delay_ms;
 
Quoted 10 lines

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 257

Quoted 7 lines
include/linux/mmc/dw_mmc.h +3 -0
@@ -249,6 +252,11 @@ struct dw_mci_board {
        struct dw_mci_dma_ops *dma_ops;
        struct dma_pdata *data;
        struct block_settings *blk_settings;
+
+       int (*get_clk_drv)(struct dw_mci *);
+       int (*get_clk_sample)(struct dw_mci *);

...and these members do not seem to be used in the rest of this patch. Should they be included?

Quoted 2 lines

These member should be used at exynos-soc.
I will also send the patch related with them.

These are needed.
Actually, we have applied it for Exynos internally.
But I can't make sure that other host can apply it with the same way.
It is a good chance that we can find out implementation of other host based on Synopsys.

Quoted 27 lines

Thanks for comments.

Best Regards,
Jaehoon Chung

Quoted 12 lines
Quoted 7 lines
include/linux/mmc/dw_mmc.h +2 -1
+       void (*set_clk_drv_sample)(struct dw_mci *host, struct mmc_ios *ios);
+
 };
 
 #endif /* LINUX_MMC_DW_MMC_H */
--
Quoted 5 lines

1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#4 lore raw
Quoted 59 lines · Seungwon Jeon
Quoted 58 lines · Jaehoon Chung

Hi Will,

Quoted 55 lines · Will Newton

On Thu, Aug 23, 2012 at 12:31 PM, Jaehoon Chung <[email protected]> wrote:

Hi Jaehoon,

Quoted 29 lines

Some SoC need to set the clock-phase shift.
So Add the callback function into platdata for using phase-shift

---
 drivers/mmc/host/dw_mmc.c  |    3 +++
 include/linux/mmc/dw_mmc.h |    8 ++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)
drivers/mmc/host/dw_mmc.c +3 -0
index 8bef3c2..feafa2d 100644
@@ -824,6 +824,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 
        mci_writel(slot->host, UHS_REG, regs);
 
+       if (slot->host->pdata->set_clk_drv_sample)
+               slot->host->pdata->set_clk_drv_sample(slot->host, ios);
+
        if (ios->clock) {
                /*
                 * Use mirror of ios->clock to prevent race with mmc
include/linux/mmc/dw_mmc.h +0 -0
index 7a7ebd3..f20979c 100644

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 234

Quoted 6 lines
include/linux/mmc/dw_mmc.h +3 -0
@@ -229,6 +229,9 @@ struct dw_mci_board {
         */
        unsigned int fifo_depth;
 
+       u32 ddr_timing;         /* DDR clock phase timing value */
+       u32 sdr_timing;         /* SDR clock phase timing value */
+

These members...

include/linux/mmc/dw_mmc.h struct dw_mci_board { · line 257

Quoted 10 lines
include/linux/mmc/dw_mmc.h +3 -0
        /* delay in mS before detecting cards after interrupt */
        u32 detect_delay_ms;
 
@@ -249,6 +252,11 @@ struct dw_mci_board {
        struct dw_mci_dma_ops *dma_ops;
        struct dma_pdata *data;
        struct block_settings *blk_settings;
+
+       int (*get_clk_drv)(struct dw_mci *);
+       int (*get_clk_sample)(struct dw_mci *);

...and these members do not seem to be used in the rest of this patch. Should they be included?

Quoted 6 lines
Quoted 2 lines

These member should be used at exynos-soc.
I will also send the patch related with them.

These are needed.
Actually, we have applied it for Exynos internally.
But I can't make sure that other host can apply it with the same way.
It is a good chance that we can find out implementation of other host based on Synopsys.

As i mentioned, these are used at Exynos.
But i think that we need to add the code like this for supporting Exynos. Thank you for comment.

Best regards,
Jaehoon Chung

Quoted 34 lines
Quoted 24 lines

Thanks for comments.

Best Regards,
Jaehoon Chung

Quoted 12 lines
Quoted 7 lines
include/linux/mmc/dw_mmc.h +2 -1
+       void (*set_clk_drv_sample)(struct dw_mci *host, struct mmc_ios *ios);
+
 };
 
 #endif /* LINUX_MMC_DW_MMC_H */
--
Quoted 5 lines

1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html