mmc: s5p_sdhci: add the set_mmc_clk for cmu control

PATCH New Jaehoon Chung 1 participant 2 messages Aug 31, 2012 1 message not in the archive MMC, SD and SDIO

lore

Share & tools

lore

Jaehoon Chung

author

2012-08-31 02:24 UTC #0 lore raw

PATCH v3 3/4 mmc: s5p_sdhci: add the set_mmc_clk for cmu control

Samsung SoC use the cmu control to set clock.

Signed-off-by Jaehoon Chung <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 drivers/mmc/s5p_sdhci.c |    3 +++
 drivers/mmc/sdhci.c     |    3 +++
 include/configs/trats.h |    1 +
 include/sdhci.h         |    2 ++
 4 files changed, 9 insertions(+), 0 deletions(-)

drivers/mmc/s5p_sdhci.c +3 -0

index 9378e36..b978236 100644
@@ -21,6 +21,7 @@
 #include <malloc.h>
 #include <sdhci.h>
 #include <asm/arch/mmc.h>
+#include <asm/arch/clk.h>
 
 static char *S5P_NAME = "SAMSUNG SDHCI";
 static void s5p_sdhci_set_control_reg(struct sdhci_host *host)

@@ -87,6 +88,8 @@ int s5p_sdhci_init(u32 regbase, int index, int bus_width)
 	host->version = sdhci_readw(host, SDHCI_HOST_VERSION);
 
 	host->set_control_reg = &s5p_sdhci_set_control_reg;
+	host->set_clock = set_mmc_clk;
+	host->index = index;
 
 	host->host_caps = MMC_MODE_HC;

drivers/mmc/sdhci.c +3 -0

index 1709643..ac39e48 100644
@@ -279,6 +279,9 @@ static int sdhci_set_clock(struct mmc *mmc, unsigned int clock)
 	}
 	div >>= 1;
 
+	if (host->set_clock)
+		host->set_clock(host->index, div);
+
 	clk = (div & SDHCI_DIV_MASK) << SDHCI_DIVIDER_SHIFT;
 	clk |= ((div & SDHCI_DIV_HI_MASK) >> SDHCI_DIV_MASK_LEN)
 		<< SDHCI_DIVIDER_HI_SHIFT;

include/configs/trats.h +1 -0

index d2dfc9f..799658f 100644
@@ -76,6 +76,7 @@
 #define CONFIG_MMC
 #define CONFIG_S5P_SDHCI
 #define CONFIG_SDHCI
+#define CONFIG_MMC_SDMA
 
 /* PWM */
 #define CONFIG_PWM

include/sdhci.h +2 -0

index 9d37183..4351a62 100644
@@ -248,8 +248,10 @@ struct sdhci_host {
 	unsigned int clock;
 	struct mmc *mmc;
 	const struct sdhci_ops *ops;
+	int index;
 
 	void (*set_control_reg)(struct sdhci_host *host);
+	void (*set_clock)(int dev_index, unsigned int div);
 	uint	voltages;
 };

Signature · 1 line

1.7.4.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jaehoon Chung

author

2012-08-31 02:46 UTC #2 lore raw

PATCH v3 3/4 mmc: s5p_sdhci: add the set_mmc_clk for cmu control

Hi Lei,

Quoted 20 lines · Lei Wen

Hi Jaehoon,
Quoted 9 lines
-----Original Message-----
From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Friday, August 31, 2012 10:24 AM
To: u-boot at lists.denx.de
Cc: Andy Fleming; Kyungmin Park; Lei Wen; John Rigby; Tushar Behera
Subject: [PATCH v3 3/4] mmc: s5p_sdhci: add the set_mmc_clk for cmu control
Samsung SoC use the cmu control to set clock.
Quoted 8 lines
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/s5p_sdhci.c |    3 +++
 drivers/mmc/sdhci.c     |    3 +++
 include/configs/trats.h |    1 +
 include/sdhci.h         |    2 ++
 4 files changed, 9 insertions(+), 0 deletions(-)

Quoted 1 line

I suggest you split this patch into two pieces, and don't mix the s5p specific changes to the sdhci overall changes, so that others could adapt such change without involve the s5p changes.

Ok i will separate them. (sdhci and s5p specific patch).

Best Regards,
Jaehoon Chung

Quoted 4 lines

Thanks,
Lei