Skip to contentSkip to conversation

vfs: correct comment for fs/fs-writeback.c/move_expired_inodes

PATCH Applied Wang Sheng-Hui 3 participants 3 messages Sep 8, 2012 – Sep 11, 2012 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vfs: correct comment for fs/fs-writeback.c/move_expired_inodes

The function scans @delaying_queue and stops at the first inode whose dirtied_when is after *work->older_than_this. So the expired ones being moved are those before *work->older_than_this. Correct the comment here.

---
 fs/fs-writeback.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fs-writeback.c +1 -1
index be3efc4..fd255c0 100644
@@ -248,7 +248,7 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
 }
 
 /*
- * Move expired (dirtied after work->older_than_this) dirty inodes from
+ * Move expired (dirtied before work->older_than_this) dirty inodes from
  * @delaying_queue to @dispatch_queue.
  */
 static int move_expired_inodes(struct list_head *delaying_queue,
Signature · 1 line
1.7.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Wang Sheng-Hui

The function scans @delaying_queue and stops at the first inode whose dirtied_when is after *work->older_than_this. So the expired ones being moved are those before *work->older_than_this. Correct the comment here.

Fengguang Wu would be a more appropriate for this. Added to CC. BTW the
patch is fine so feel free to add:

Honza

Quoted 25 lines
---
 fs/fs-writeback.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fs-writeback.c +1 -1
index be3efc4..fd255c0 100644
@@ -248,7 +248,7 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
 }
 
 /*
- * Move expired (dirtied after work->older_than_this) dirty inodes from
+ * Move expired (dirtied before work->older_than_this) dirty inodes from
  * @delaying_queue to @dispatch_queue.
  */
 static int move_expired_inodes(struct list_head *delaying_queue,
Signature · 5 lines
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
Applied
#2 lore raw
Quoted 9 lines · Jan Kara
Quoted 4 lines · Wang Sheng-Hui

The function scans @delaying_queue and stops at the first inode whose dirtied_when is after *work->older_than_this. So the expired ones being moved are those before *work->older_than_this. Correct the comment here.

Fengguang Wu would be a more appropriate for this. Added to CC. BTW the
patch is fine so feel free to add:

Applied. Thank you!

Fengguang