Replace genphy_update_link() call with phy_read_status()
Subsystems (3)
PATCH 1/1 Replace genphy_update_link() call with phy_read_status()
From: Alexander Sverdlin <[email protected]>
Replace genphy_update_link() call with phy_read_status()
Code in phy.c should not call genphy_*() functions directly, this breaks PHY layer abstraction. Some drivers may re-implement "read_status" callback and it's not being called in one place of PHY state machine, where genphy_update_link() is called instead. So fix it.
For drivers that rely on genphy_* implementation nothing changed, as genphy_read_status() calls genphy_update_link() anyway.
Signed-off-by Alexander Sverdlin <[email protected]>
--- drivers/net/phy/phy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/phy/phy.c +1 -1
@@ -839,7 +839,7 @@ void phy_state_machine(struct work_struct *work) }break ;case PHY_FORCING : - err =genphy_update_link (phydev); + err =phy_read_status (phydev);if (err)break ;