Skip to contentSkip to conversation

mmc: sdhci-s3c: fix the wrong number of max bus clock

PATCH In review Jaehoon Chung 2 participants 2 messages Sep 18, 2012 – Sep 19, 2012

Subsystems (3)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Secure digital host controller interface (SDHCI) Samsung driver
lore
Share & tools
lore

Jaehoon Chung

author maintainer
#0 lore raw

PATCH 1/1 mmc: sdhci-s3c: fix the wrong number of max bus clock

We can use the four bus-clock at sdhci-s3c.c But when removed, didn't check the fourth bus clock.

Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/host/sdhci-s3c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/sdhci-s3c.c +1 -1
index 0c77b10..f2b76ef 100644
@@ -788,7 +788,7 @@ static int __devexit sdhci_s3c_remove(struct platform_device *pdev)
 
 	pm_runtime_disable(&pdev->dev);
 
-	for (ptr = 0; ptr < 3; ptr++) {
+	for (ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
 		if (sc->clk_bus[ptr]) {
 			clk_disable(sc->clk_bus[ptr]);
 			clk_put(sc->clk_bus[ptr]);
Signature · 1 line
1.7.4.1
#1 lore raw

Hi,

Quoted 14 lines · Jaehoon Chung

We can use the four bus-clock at sdhci-s3c.c But when removed, didn't check the fourth bus clock.

Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/host/sdhci-s3c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/sdhci-s3c.c +0 -0
index 0c77b10..f2b76ef 100644

drivers/mmc/host/sdhci-s3c.c static int __devexit sdhci_s3c_remove(struct platform_device *pdev) · line 794

Quoted 8 lines
drivers/mmc/host/sdhci-s3c.c +1 -1
@@ -788,7 +788,7 @@ static int __devexit sdhci_s3c_remove(struct platform_device *pdev)
 
 	pm_runtime_disable(&pdev->dev);
 
-	for (ptr = 0; ptr < 3; ptr++) {
+	for (ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
 		if (sc->clk_bus[ptr]) {
 			clk_disable(sc->clk_bus[ptr]);
 			clk_put(sc->clk_bus[ptr]);

Thanks, pushed to mmc-next for 3.7 with a stable@ tag.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child