Skip to contentSkip to conversation

Audio codec volume control

DISCUSSION Rajeev kumar 2 participants 6 messages Sep 20, 2012

lore
Share & tools
lore
#0 lore raw

Hello Mark,

We have three volume control in audio codec.
1. Master volume: control both left and right channel volume
2. left volume: control left channel vol
3. right volume: control right channel vol.

So we can provide interfaces for all volume control to the user. Please find below the control I can provide to the user space

case 1:
1. Provide master volume control
2. Provide Left channel volume control.
3. Provide Right channel volume control.

case 2:

1. Provide master volume control
2. Instead of providing separate control for left and right channel,
combined it and provide a single control to user space. so that left and right volume is always in sync.

Please let me know which case is better and why?

Thank you very much for your support.

Best Regards
Rajeev

#1 lore raw
Quoted 15 lines · Rajeev kumar

Hello Mark,

We have three volume control in audio codec.
1. Master volume: control both left and right channel volume
2. left volume: control left channel vol
3. right volume: control right channel vol.

So we can provide interfaces for all volume control to the user. Please find below the control I can provide to the user space

case 1:
1. Provide master volume control
2. Provide Left channel volume control.
3. Provide Right channel volume control.

Quoted 6 lines

case 2:

1. Provide master volume control
2. Instead of providing separate control for left and right channel, combined it and provide a single control to user space. so that left and right volume is always in sync.

case 3:
1. Provide master volume control
2. stereo volume control for the left/right channel

Signature · 1 line
Péter
#2 lore raw

Hello Peter

Quoted 18 lines · Peter Ujfalusi
Quoted 17 lines · Rajeev kumar

Hello Mark,

We have three volume control in audio codec.
1. Master volume: control both left and right channel volume
2. left volume: control left channel vol
3. right volume: control right channel vol.

So we can provide interfaces for all volume control to the user. Please find below the control I can provide to the user space

case 1:
1. Provide master volume control
2. Provide Left channel volume control.
3. Provide Right channel volume control.

case 2:

Quoted 9 lines
Quoted 4 lines

1. Provide master volume control
2. Instead of providing separate control for left and right channel, combined it and provide a single control to user space. so that left and right volume is always in sync.

case 3:
1. Provide master volume control
2. stereo volume control for the left/right channel

You mean to say
Left and Right should be a single stereo control which can be provided with SOC_DOUBLE. Actually case 2 corresponds to the same setting which you are suggesting.

But why this is better option?

In case user wants a separate left/right volume control then how this setting is going to help.

Best Rgds
~Rajeev

#3 lore raw
Quoted 11 lines · Rajeev kumar
Quoted 4 lines

case 3:
1. Provide master volume control
2. stereo volume control for the left/right channel

You mean to say
Left and Right should be a single stereo control which can be provided with SOC_DOUBLE. Actually case 2 corresponds to the same setting which you are suggesting.

But why this is better option?

You have less controls for the codec -> easier for users. Users still can adjust the left/right differently if they want.

Quoted 2 lines

In case user wants a separate left/right volume control then how this setting is going to help.

In most cases you change both left/right channel:
amixer sset 'PCM' 8 # left/right volume is 8

but users can set different volume per channel:
amixer sset 'PCM' 8,1 # left volume is 8, right is 1

it is better than:
amixer sset 'PCM Left' 8 # left volume is 8
amixer sset 'PCM Right' 8 # left volume is 8

or
amixer sset 'PCM Left' 8 # left volume is 8
amixer sset 'PCM Right' 1 # left volume is 1

Signature · 1 line
Péter
#4 lore raw

Hello Peter,

Quoted 25 lines · Peter Ujfalusi
Quoted 11 lines · Rajeev kumar
Quoted 4 lines

case 3:
1. Provide master volume control
2. stereo volume control for the left/right channel

You mean to say
Left and Right should be a single stereo control which can be provided with SOC_DOUBLE. Actually case 2 corresponds to the same setting which you are suggesting.

But why this is better option?

You have less controls for the codec -> easier for users. Users still can adjust the left/right differently if they want.

Quoted 2 lines

In case user wants a separate left/right volume control then how this setting is going to help.

In most cases you change both left/right channel:
amixer sset 'PCM' 8 # left/right volume is 8

but users can set different volume per channel:
amixer sset 'PCM' 8,1 # left volume is 8, right is 1

Quoted 8 lines

it is better than:
amixer sset 'PCM Left' 8 # left volume is 8
amixer sset 'PCM Right' 8 # left volume is 8

or
amixer sset 'PCM Left' 8 # left volume is 8
amixer sset 'PCM Right' 1 # left volume is 1

Thanks for the info.

Please find below the controls I have provided

static const char *pwm_mode_text[] = { "Binary", "Headphone", "Ternary",

        "Phase-shift"};

static const DECLARE_TLV_DB_SCALE(out_gain_tlv, -9150, 50, 0); static const DECLARE_TLV_DB_SCALE(master_vol_tlv, -12750, 50, 0); static const SOC_ENUM_SINGLE_DECL(pwm_src, STA529_FFXCFG1, 4, pwm_mode_text);

static const struct snd_kcontrol_new sta529_snd_controls[] = {
SOC_DOUBLE_R_TLV("Digital Playback Volume", STA529_LVOL,
STA529_RVOL, 0,

                        127, 0, out_gain_tlv),
        SOC_SINGLE_TLV("Master Playback Volume", STA529_MVOL, 0, 127, 1,
                        master_vol_tlv),
        SOC_ENUM("PWM Select", pwm_src),
};

So in our amixer output I am not getting any separate numid for left/right volume, so that user can control it.

Is there something I am missing in my code.

Best Regards
Rajeev

#5 lore raw
Quoted 22 lines · Rajeev kumar

Hello Peter,

On 9/20/2012 3:49 PM, Peter Ujfalusi wrote:
Thanks for the info.

Please find below the controls I have provided

static const char *pwm_mode_text[] = { "Binary", "Headphone", "Ternary",

        "Phase-shift"};

static const DECLARE_TLV_DB_SCALE(out_gain_tlv, -9150, 50, 0); static const DECLARE_TLV_DB_SCALE(master_vol_tlv, -12750, 50, 0); static const SOC_ENUM_SINGLE_DECL(pwm_src, STA529_FFXCFG1, 4, pwm_mode_text);

static const struct snd_kcontrol_new sta529_snd_controls[] = {
        SOC_DOUBLE_R_TLV("Digital Playback Volume", STA529_LVOL, STA529_RVOL, 0,
                        127, 0, out_gain_tlv),
        SOC_SINGLE_TLV("Master Playback Volume", STA529_MVOL, 0, 127, 1,
                        master_vol_tlv),
        SOC_ENUM("PWM Select", pwm_src),
};
Quoted 2 lines

So in our amixer output I am not getting any separate numid for left/right volume, so that user can control it.

You should have single numid for the stereo control:
amixer sget Digital

amixer sget Master

You should see something like this with the stereo control:

beagle-gentoo dapm # amixer sget Headset
Simple mixer control 'Headset',0
Capabilities: pvolume penum
Playback channels: Front Left - Front Right
Limits: Playback 0 - 3
Mono:
Front Left: Playback 2 [67%] [0.00dB]
Front Right: Playback 2 [67%] [0.00dB]

Quoted 2 lines

Is there something I am missing in my code.

Looks fine for me.

Signature · 1 line
Péter