Skip to contentSkip to conversation

ASoC: intel: rt5640: add support for sound card found on HP Pavilion x2 10-p000

PATCH In review Alexandrov Stanislav 2 participants 2 messages Jan 3, 2017 – Jan 4, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: intel: rt5640: add support for sound card found on HP Pavilion x2 10-p000

Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

Inside DSDT table there is record for this soundcard:

            Device (RTKC)
            {
                Name (_ADR, Zero)  // _ADR: Address
                Name (_HID, "10EC3276")  // _HID: Hardware ID
                Name (_CID, "10EC3276")  // _CID: Compatible ID
                Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                Name (_PR0, Package (0x01)  // _PR0: Power Resources for 

D0

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

---

sound/soc/codecs/rt5640.c +1 -0
index e29a6de..c5234b9 100644
@@ -2315,6 +2315,7 @@ static const struct acpi_device_id rt5640_acpi_match[] = {
        { "INT33CA", 0 },
        { "10EC5640", 0 },
        { "10EC5642", 0 },
+       { "10EC3276", 0 },
        { "INTCCFFD", 0 },
        { },
 };
sound/soc/intel/atom/sst/sst_acpi.c +0 -0
index f4d92bb..896ced2 100644
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
        /* some CHT-T platforms rely on RT5640, use Baytrail machine 

driver */

        {"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", 

"bytcr_rt5640", cht_quirk,
&chv_platform_data },
+ {"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
+ &chv_platform_data },

        {},

};

#1 lore raw
Quoted 13 lines · Alexandrov Stanislav

Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

Inside DSDT table there is record for this soundcard:

            Device (RTKC)
            {
                Name (_ADR, Zero)  // _ADR: Address
                Name (_HID, "10EC3276")  // _HID: Hardware ID
                Name (_CID, "10EC3276")  // _CID: Compatible ID
                Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                Name (_PR0, Package (0x01)  // _PR0: Power Resources
Quoted 3 lines

for D0

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

Hi,

Thanks for the patch, changes look okay, but they need to be split per driver and you need to sign-off these changes.
See Documentation/process/submitting-patches.rst esp Section 11.

Quoted 33 lines

---

sound/soc/codecs/rt5640.c +1 -0
index e29a6de..c5234b9 100644
@@ -2315,6 +2315,7 @@ static const struct acpi_device_id
 rt5640_acpi_match[] = {
        { "INT33CA", 0 },
        { "10EC5640", 0 },
        { "10EC5642", 0 },
+       { "10EC3276", 0 },
        { "INTCCFFD", 0 },
        { },

};

sound/soc/intel/atom/sst/sst_acpi.c +0 -0
index f4d92bb..896ced2 100644
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
        /* some CHT-T platforms rely on RT5640, use Baytrail machine

driver */

        {"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin",

"bytcr_rt5640", cht_quirk,
&chv_platform_data },
+ {"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin",
"bytcr_rt5640", NULL,
+ &chv_platform_data },

        {},

};

Signature · 1 line
~Vinod