Skip to contentSkip to conversation

bcma: fix unregistration of cores

PATCH New Piotr Haber 1 participant 1 message Oct 11, 2012 Broadcom specific amba driver (bcma)

lore
Share & tools
lore

Piotr Haber

author
#0 lore raw

PATCH 1/1 bcma: fix unregistration of cores

When cores are unregistered, entries
need to be removed from cores list in a safe manner.

Reported-by Stanislaw Gruszka <[email protected]>
Reviewed-by Arend Van Spriel <[email protected]>
Signed-off-by Piotr Haber <[email protected]>
Cc [email protected]
---
 drivers/bcma/main.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bcma/main.c +3 -2
index 758af9c..0059e26 100644
@@ -141,9 +141,10 @@ static int bcma_register_cores(struct bcma_bus *bus)
 
 static void bcma_unregister_cores(struct bcma_bus *bus)
 {
-	struct bcma_device *core;
+	struct bcma_device *core, *tmp;
 
-	list_for_each_entry(core, &bus->cores, list) {
+	list_for_each_entry_safe(core, tmp, &bus->cores, list) {
+		list_del(&core->list);
 		if (core->dev_registered)
 			device_unregister(&core->dev);
 	}
Signature · 1 line
1.7.10.4