Kernel 3.7.0-rc1 crash on i915 unlock_page
Subsystems (2)
[adding relevant mailing lists.]
Quoted 9 lines · Krzysztof Kolasa
crash : unlock page,
shmem_read_mapping_page_gfp,i915_gem_object_get_pages_gttlaptop AMILO Pro V3405 with 2GB, kernel 32bit/PAE
error screenshot :
https://docs.google.com/open?id=0B1LAMAFWTdewbjFGSFNFcTNGSFE
Unfortunately the oops has scrolled off a bit. Can you try to grab a full backtrace, either with netconsole or by using a higher screen resolution (so that the entire thing fits)?
Thanks, Daniel
Quoted 3 lines
Krzysztof
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
PATCH 1/1 drm/i915: Initialize obj->pages before use by i915_gem_object_do_bit17_swizzle()
In reply to a message not in the archiveIf we leave obj->pages set to NULL before attempting to deswizzle them, then an OOPS is well deserved.
Fixes regression introduced in commit 9da3da660d8c19a54f6e93361d147509be3fff84
Author: Chris Wilson <[email protected]> Date: Fri Jun 1 15:20:22 2012 +0100
drm/i915: Replace the array of pages with a scatterlist
--- drivers/gpu/drm/i915/i915_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +2 -1
@@ -1953,10 +1953,11 @@ i915_gem_object_get_pages_gtt(struct drm_i915_gem_object *obj)sg_set_page (sg, page,PAGE_SIZE ,0 ); } + obj->pages = st; +if (i915_gem_object_needs_bit17_swizzle (obj))i915_gem_object_do_bit_17_swizzle (obj); - obj->pages = st;return 0 ; err_pages:
Signature · 1 line
1.7.10.4
Re: [PATCH] drm/i915: Initialize obj->pages before use by i915_gem_object_do_bit17_swizzle()
Quoted 23 lines · On Fri, 19 Oct 2012 15:51:06 +0100 Chris Wilson <[email protected]>…
If we leave
obj->pagesset to NULL before attempting to deswizzle them, then an OOPS is well deserved.Fixes regression introduced in commit
9da3da660d8c19a54f6e93361d147509be3fff84Author: Chris Wilson <[email protected]> Date: Fri Jun 1 15:20:22 2012 +0100drm/i915: Replace the array of pages with a scatterlist
--- drivers/gpu/drm/i915/i915_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem.c +0
-0@@ -1953,10 +1953,11 @@ i915_gem_object_get_pages_gtt(struct drm_i915_gem_object *obj)sg_set_page (sg, page,PAGE_SIZE ,0 ); }
drivers/gpu/drm/i915/i915_gem.c i915_gem_object_get_pages_gtt(struct drm_i915_gem_object *obj) · line 1963
Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +2
-1+ obj->pages = st; +if (i915_gem_object_needs_bit17_swizzle (obj))i915_gem_object_do_bit_17_swizzle (obj); - obj->pages = st;return 0 ; err_pages:
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
Re: [PATCH] drm/i915: Initialize obj->pages before use by i915_gem_object_do_bit17_swizzle()
In reply to Chris WilsonQuoted 23 lines · Chris Wilson
If we leave
obj->pagesset to NULL before attempting to deswizzle them, then an OOPS is well deserved.Fixes regression introduced in commit
9da3da660d8c19a54f6e93361d147509be3fff84Author: Chris Wilson <[email protected]> Date: Fri Jun 1 15:20:22 2012 +0100drm/i915: Replace the array of pages with a scatterlist
--- drivers/gpu/drm/i915/i915_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem.c +0
-0@@ -1953,10 +1953,11 @@ i915_gem_object_get_pages_gtt(struct drm_i915_gem_object *obj)sg_set_page (sg, page,PAGE_SIZE ,0 ); }
drivers/gpu/drm/i915/i915_gem.c i915_gem_object_get_pages_gtt(struct drm_i915_gem_object *obj) · line 1963
Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +2
-1+ obj->pages = st; +if (i915_gem_object_needs_bit17_swizzle (obj))i915_gem_object_do_bit_17_swizzle (obj); - obj->pages = st;return 0 ; err_pages:
Patch solves the problem.
Thanks.
Krzysztof
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx