Skip to contentSkip to conversation

socfpga/spl: Cleanup

PATCH New Vikram Narayanan 4 participants 7 messages Oct 23, 2012 – Nov 10, 2012 Arm (32-bit)

lore
Share & tools
lore

Vikram Narayanan

author
#0 lore raw

cover socfpga/spl: Cleanup

Cleanups for SPL/socfpga.

Cc Dinh Nguyen <[email protected]>

Vikram Narayanan (2):
arm/socfpga: Remove timer_init from spl_board_init socfpga/spl: Remove malloc.h

 arch/arm/cpu/armv7/socfpga/spl.c   |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.4.1
author
#1 lore raw

PATCH 1/2 socfpga/spl: Remove timer_init from spl_board_init

Timer is initialized already in board_init_r function in (common/spl/spl.c) No need to initialize it again

Signed-off-by Vikram Narayanan <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
 arch/arm/cpu/armv7/socfpga/spl.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
arch/arm/cpu/armv7/socfpga/spl.c +0 -3
index 944238b..23053fd 100644
@@ -37,9 +37,6 @@ u32 spl_boot_device(void)
  */
 void spl_board_init(void)
 {
-	/* init timer for enabling delay function */
-	timer_init();
-
 	/* de-assert reset for peripherals and bridges based on handoff */
 	reset_deassert_peripherals_handoff();
Signature · 1 line
1.7.4.1
author
#3 lore raw

PATCH 2/2 socfpga/spl: Remove malloc.h

In reply to Vikram Narayanan

Remove unused header

Signed-off-by Vikram Narayanan <[email protected]>
---
 arch/arm/cpu/armv7/socfpga/spl.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/socfpga/spl.c +0 -1
index 23053fd..84216eb 100644
@@ -21,7 +21,6 @@
 #include <asm/utils.h>
 #include <version.h>
 #include <image.h>
-#include <malloc.h>
 #include <asm/arch/reset_manager.h>
 #include <spl.h>
Signature · 1 line
1.7.4.1
#5 lore raw

cover socfpga/spl: Cleanup

In reply to Vikram Narayanan

Hi Vikram,

Quoted 7 lines · Vikram Narayanan

Cleanups for SPL/socfpga.

Cc Dinh Nguyen <[email protected]>

Vikram Narayanan (2):
arm/socfpga: Remove timer_init from spl_board_init socfpga/spl: Remove malloc.h

Do you need to split up the patches? Otherwise,

Acked-by Dinh Nguyen <[email protected]>

Dinh

Quoted 4 lines
 arch/arm/cpu/armv7/socfpga/spl.c   |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
#6 lore raw

cover socfpga/spl: Cleanup

Quoted 7 lines · Dinh Nguyen

Hi Vikram,

Quoted 4 lines · Vikram Narayanan

Cleanups for SPL/socfpga.

Cc Dinh Nguyen <[email protected]>
Quoted 7 lines
Quoted 3 lines

Vikram Narayanan (2):
arm/socfpga: Remove timer_init from spl_board_init socfpga/spl: Remove malloc.h

Do you need to split up the patches? Otherwise,

Acked-by Dinh Nguyen <[email protected]>

The patches are single-(functional)-line each, I think they are split up pretty perfectly.

Acked-by Pavel Machek <[email protected]>

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw

PATCH 1/2 socfpga/spl: Remove timer_init from spl_board_init

In reply to Vikram Narayanan

Hi Vikram,

Quoted 14 lines · Vikram Narayanan

Timer is initialized already in board_init_r function in (common/spl/spl.c) No need to initialize it again

Signed-off-by Vikram Narayanan <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
 arch/arm/cpu/armv7/socfpga/spl.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
arch/arm/cpu/armv7/socfpga/spl.c +0 -0
index 944238b..23053fd 100644

arch/arm/cpu/armv7/socfpga/spl.c u32 spl_boot_device(void) · line 42

Quoted 9 lines
arch/arm/cpu/armv7/socfpga/spl.c +0 -3
@@ -37,9 +37,6 @@ u32 spl_boot_device(void)
  */
 void spl_board_init(void)
 {
-	/* init timer for enabling delay function */
-	timer_init();
-
 	/* de-assert reset for peripherals and bridges based on handoff */
 	reset_deassert_peripherals_handoff();

Applied to u-boot-arm/master, thanks!

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH 2/2 socfpga/spl: Remove malloc.h

In reply to Vikram Narayanan

Hi Vikram,

Quoted 12 lines · Vikram Narayanan

Remove unused header

Signed-off-by Vikram Narayanan <[email protected]>
---
 arch/arm/cpu/armv7/socfpga/spl.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/socfpga/spl.c +0 -0
index 23053fd..84216eb 100644

arch/arm/cpu/armv7/socfpga/spl.c line 26

Quoted 7 lines
arch/arm/cpu/armv7/socfpga/spl.c +0 -1
@@ -21,7 +21,6 @@
 #include <asm/utils.h>
 #include <version.h>
 #include <image.h>
-#include <malloc.h>
 #include <asm/arch/reset_manager.h>
 #include <spl.h>

Note: this was applied to u-boot-arm/master along with 1/2.

Amicalement,

Signature · 1 line
Albert.