Samsung media drivers fixes

GIT PULL Sylwester Nawrocki 3 participants 6 messages Oct 25, 2012 – Oct 27, 2012 Media (V4L/DVB)

lore

Share & tools

lore

Sylwester Nawrocki

author

2012-10-25 16:01 UTC #0 lore raw

Hi Mauro,

please pull following fixes for v3.7-rc.

The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:

[media] m5mols: Add missing #include <linux/sizes.h> (2012-10-10 08:17:16 -0300)

are available in the git repository at:

git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7

for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:

s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)

----------------------------------------------------------------
Jesper Juhl (1):
s5p-tv: don't include linux/version.h in mixer_video.c

Sachin Kamat (5):
s5p-mfc: Fix compilation warning
exynos-gsc: Fix compilation warning
s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
s5p-fimc: Make 'fimc_pipeline_s_stream' function static
s5p-fimc: Fix potential NULL pointer dereference

Shaik Ameer Basha (3):
exynos-gsc: change driver compatible string
exynos-gsc: fix variable type in gsc_m2m_device_run()
s5p-fimc: fix variable type in fimc_device_run()

Sylwester Nawrocki (4):
s5p-fimc: Don't ignore return value of vb2_queue_init()
s5p-csis: Select S5P_SETUP_MIPIPHY
s5p-fimc: Add missing new line character
s5p-fimc: Fix platform entities registration

 drivers/media/platform/exynos-gsc/gsc-core.c   |    8 +++--
 drivers/media/platform/exynos-gsc/gsc-m2m.c    |    2 +-
 drivers/media/platform/s5p-fimc/Kconfig        |    1 +
 drivers/media/platform/s5p-fimc/fimc-capture.c |    4 ++-
 drivers/media/platform/s5p-fimc/fimc-lite.c    |    4 ++-
 drivers/media/platform/s5p-fimc/fimc-m2m.c     |    2 +-
 drivers/media/platform/s5p-fimc/fimc-mdevice.c |   45 ++++++++++++------------
 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c   |    2 +-
 drivers/media/platform/s5p-mfc/s5p_mfc_pm.c    |    2 +-
 drivers/media/platform/s5p-tv/mixer_video.c    |    1 -
 10 files changed, 38 insertions(+), 33 deletions(-)

Thanks,
Sylwester

Mauro Carvalho Chehab

2012-10-25 16:46 UTC #1 lore raw

Em Thu, 25 Oct 2012 18:01:17 +0200
Sylwester Nawrocki <[email protected]> escreveu:

Quoted 32 lines

Hi Mauro,
please pull following fixes for v3.7-rc.
The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
[media] m5mols: Add missing #include <linux/sizes.h> (2012-10-10 08:17:16 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
----------------------------------------------------------------
Jesper Juhl (1):
s5p-tv: don't include linux/version.h in mixer_video.c
Sachin Kamat (5):
s5p-mfc: Fix compilation warning
exynos-gsc: Fix compilation warning
s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
s5p-fimc: Make 'fimc_pipeline_s_stream' function static
s5p-fimc: Fix potential NULL pointer dereference
Shaik Ameer Basha (3):
exynos-gsc: change driver compatible string
exynos-gsc: fix variable type in gsc_m2m_device_run()
s5p-fimc: fix variable type in fimc_device_run()

Quoted 5 lines

Sylwester Nawrocki (4):
s5p-fimc: Don't ignore return value of vb2_queue_init()
s5p-csis: Select S5P_SETUP_MIPIPHY
s5p-fimc: Add missing new line character
s5p-fimc: Fix platform entities registration

Only a few of the above seems to be material for -rc:
s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
s5p-fimc: Fix platform entities registration (60 seconds ago)
s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)

The other ones are warnings/sparse warnings and cleanups. I'll be applying only the 4 above patches for 3.7, adding the other ones for 3.8.

Regards,
Mauro

Sylwester Nawrocki

2012-10-25 18:59 UTC #2 lore raw

Quoted 48 lines · Mauro Carvalho Chehab

Em Thu, 25 Oct 2012 18:01:17 +0200
Sylwester Nawrocki<[email protected]> escreveu:
Quoted 32 lines
Hi Mauro,
please pull following fixes for v3.7-rc.
The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
   [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
   s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
----------------------------------------------------------------
Jesper Juhl (1):
s5p-tv: don't include linux/version.h in mixer_video.c
Sachin Kamat (5):
s5p-mfc: Fix compilation warning
exynos-gsc: Fix compilation warning
s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
s5p-fimc: Make 'fimc_pipeline_s_stream' function static
s5p-fimc: Fix potential NULL pointer dereference
Shaik Ameer Basha (3):
exynos-gsc: change driver compatible string
exynos-gsc: fix variable type in gsc_m2m_device_run()
s5p-fimc: fix variable type in fimc_device_run()
Quoted 5 lines
Sylwester Nawrocki (4):
s5p-fimc: Don't ignore return value of vb2_queue_init()
s5p-csis: Select S5P_SETUP_MIPIPHY
s5p-fimc: Add missing new line character
s5p-fimc: Fix platform entities registration
Only a few of the above seems to be material for -rc:
s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
s5p-fimc: Fix platform entities registration (60 seconds ago)
s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)

Quoted 3 lines

The other ones are warnings/sparse warnings and cleanups. I'll be applying only the 4 above patches for 3.7, adding the other ones for 3.8.

Sorry for mixing them up. Except those 4, "exynos-gsc: change driver compatible string" really needs to go in 3.7. Bootloaders will be supplying an FDT node for this device with compatible string "samsung,exynos5-gsc", not "samsung,exynos5250-gsc". In case this patch is applied only starting from 3.8, kernels 3.7, where the GScaler driver was first added, will have broken support for this device. Hence this patch should be considered as a real bug fix.

For those embedded systems it might not be a big deal, since it rarely happens pure mainline kernel is used for production. But in principle it's better to apply that patch, to avoid mess where different kernels require different compatible string. This would mean an ABI breakage.

Thanks,
Sylwester

Sylwester Nawrocki

author

2012-10-26 10:15 UTC #3 lore raw

Quoted 49 lines · Sylwester Nawrocki

Quoted 48 lines · Mauro Carvalho Chehab
Em Thu, 25 Oct 2012 18:01:17 +0200
Sylwester Nawrocki<[email protected]> escreveu:
Quoted 32 lines
Hi Mauro,
please pull following fixes for v3.7-rc.
The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
   [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
   s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
----------------------------------------------------------------
Jesper Juhl (1):
s5p-tv: don't include linux/version.h in mixer_video.c
Sachin Kamat (5):
s5p-mfc: Fix compilation warning
exynos-gsc: Fix compilation warning
s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
s5p-fimc: Make 'fimc_pipeline_s_stream' function static
s5p-fimc: Fix potential NULL pointer dereference
Shaik Ameer Basha (3):
exynos-gsc: change driver compatible string
exynos-gsc: fix variable type in gsc_m2m_device_run()
s5p-fimc: fix variable type in fimc_device_run()
Quoted 5 lines
Sylwester Nawrocki (4):
s5p-fimc: Don't ignore return value of vb2_queue_init()
s5p-csis: Select S5P_SETUP_MIPIPHY
s5p-fimc: Add missing new line character
s5p-fimc: Fix platform entities registration
Only a few of the above seems to be material for -rc:
s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
s5p-fimc: Fix platform entities registration (60 seconds ago)
s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)

Quoted 3 lines

Quoted 3 lines
The other ones are warnings/sparse warnings and cleanups. I'll be applying only the 4 above patches for 3.7, adding the other ones for 3.8.

I've noticed "s5p-fimc: Fix platform entities registration" will cause a race condition. Can you please drop entirely these two patches from the 3.7 queue:

s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
s5p-fimc: Fix platform entities registration (60 seconds ago)
?

Alternatively I can send a subsequent follow up patch.

Quoted 8 lines

Sorry for mixing them up. Except those 4, "exynos-gsc: change driver compatible string" really needs to go in 3.7. Bootloaders will be supplying an FDT node for this device with compatible string "samsung,exynos5-gsc", not "samsung,exynos5250-gsc". In case this patch is applied only starting from 3.8, kernels 3.7, where the GScaler driver was first added, will have broken support for this device. Hence this patch should be considered as a real bug fix.

Quoted 4 lines

For those embedded systems it might not be a big deal, since it rarely happens pure mainline kernel is used for production. But in principle it's better to apply that patch, to avoid mess where different kernels require different compatible string. This would mean an ABI breakage.

--
Regards,
Sylwester

Mauro Carvalho Chehab

2012-10-27 10:29 UTC #4 lore raw

Em Fri, 26 Oct 2012 12:15:41 +0200
Sylwester Nawrocki <[email protected]> escreveu:

Quoted 62 lines · Sylwester Nawrocki

Quoted 49 lines · Mauro Carvalho Chehab
Quoted 48 lines
Em Thu, 25 Oct 2012 18:01:17 +0200
Sylwester Nawrocki<[email protected]> escreveu:
Quoted 32 lines
Hi Mauro,
please pull following fixes for v3.7-rc.
The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
   [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
   s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
----------------------------------------------------------------
Jesper Juhl (1):
s5p-tv: don't include linux/version.h in mixer_video.c
Sachin Kamat (5):
s5p-mfc: Fix compilation warning
exynos-gsc: Fix compilation warning
s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
s5p-fimc: Make 'fimc_pipeline_s_stream' function static
s5p-fimc: Fix potential NULL pointer dereference
Shaik Ameer Basha (3):
exynos-gsc: change driver compatible string
exynos-gsc: fix variable type in gsc_m2m_device_run()
s5p-fimc: fix variable type in fimc_device_run()
Quoted 5 lines
Sylwester Nawrocki (4):
s5p-fimc: Don't ignore return value of vb2_queue_init()
s5p-csis: Select S5P_SETUP_MIPIPHY
s5p-fimc: Add missing new line character
s5p-fimc: Fix platform entities registration
Only a few of the above seems to be material for -rc:
s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
s5p-fimc: Fix platform entities registration (60 seconds ago)
s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)
Quoted 3 lines
Quoted 3 lines
The other ones are warnings/sparse warnings and cleanups. I'll be applying only the 4 above patches for 3.7, adding the other ones for 3.8.
I've noticed "s5p-fimc: Fix platform entities registration" will cause a race condition. Can you please drop entirely these two patches from the 3.7 queue:
(quoted diff) +0 -0
 	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
 	s5p-fimc: Fix platform entities registration (60 seconds ago)
?

Quoted 1 line

Alternatively I can send a subsequent follow up patch.

As I already applied pinchartl patches on my 3.7 sandbox, I prefer if you could send it as a follow up patch.

Regards,
Mauro

Mauro Carvalho Chehab

2012-10-27 10:19 UTC #5 lore raw

In reply to Sylwester Nawrocki

Em Thu, 25 Oct 2012 20:59:09 +0200
Sylwester Nawrocki <[email protected]> escreveu:

Quoted 61 lines · Mauro Carvalho Chehab

Quoted 48 lines
Em Thu, 25 Oct 2012 18:01:17 +0200
Sylwester Nawrocki<[email protected]> escreveu:
Quoted 32 lines
Hi Mauro,
please pull following fixes for v3.7-rc.
The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
   [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
   s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
----------------------------------------------------------------
Jesper Juhl (1):
s5p-tv: don't include linux/version.h in mixer_video.c
Sachin Kamat (5):
s5p-mfc: Fix compilation warning
exynos-gsc: Fix compilation warning
s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
s5p-fimc: Make 'fimc_pipeline_s_stream' function static
s5p-fimc: Fix potential NULL pointer dereference
Shaik Ameer Basha (3):
exynos-gsc: change driver compatible string
exynos-gsc: fix variable type in gsc_m2m_device_run()
s5p-fimc: fix variable type in fimc_device_run()
Quoted 5 lines
Sylwester Nawrocki (4):
s5p-fimc: Don't ignore return value of vb2_queue_init()
s5p-csis: Select S5P_SETUP_MIPIPHY
s5p-fimc: Add missing new line character
s5p-fimc: Fix platform entities registration
Only a few of the above seems to be material for -rc:
s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
s5p-fimc: Fix platform entities registration (60 seconds ago)
s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)
Quoted 3 lines
The other ones are warnings/sparse warnings and cleanups. I'll be applying only the 4 above patches for 3.7, adding the other ones for 3.8.
Sorry for mixing them up. Except those 4, "exynos-gsc: change driver compatible string" really needs to go in 3.7. Bootloaders will be supplying an FDT node for this device with compatible string "samsung,exynos5-gsc", not "samsung,exynos5250-gsc". In case this patch is applied only starting from 3.8, kernels 3.7, where the GScaler driver was first added, will have broken support for this device. Hence this patch should be considered as a real bug fix.

Quoted 4 lines

For those embedded systems it might not be a big deal, since it rarely happens pure mainline kernel is used for production. But in principle it's better to apply that patch, to avoid mess where different kernels require different compatible string. This would mean an ABI breakage.

Ok, added it at my 3.7 sandbox.

Regards,
Mauro