Skip to contentSkip to conversation

mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

PATCH Superseded Jaehoon Chung 3 participants 3 messages Oct 26, 2012

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jaehoon Chung

author maintainer
#0 lore raw

PATCH 1/1 mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

I think right that dw_mci_setup_bus() is called into set_ios(). Actually clock is enabled at dw_mci_setup_bus() in now. Then didn't ensure to wait the 74clock.
To stable clock is relocated the position into dw_mci_set_ios().

---
 drivers/mmc/host/dw_mmc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mmc/host/dw_mmc.c +3 -3
index 250aa18..9001844 100644
@@ -682,9 +682,6 @@ static void __dw_mci_start_request(struct dw_mci *host,
 	if (host->pdata->select_slot)
 		host->pdata->select_slot(slot->id);
 
-	/* Slot specific timing and width adjustment */
-	dw_mci_setup_bus(slot);
-
 	host->cur_slot = slot;
 	host->mrq = mrq;
 
@@ -810,6 +807,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 	if (slot->host->drv_data->set_ios)
 		slot->host->drv_data->set_ios(slot->host, ios);
 
+	/* Slot specific timing and width adjustment */
+	dw_mci_setup_bus(slot);
+
 	switch (ios->power_mode) {
 	case MMC_POWER_UP:
 		set_bit(DW_MMC_CARD_NEED_INIT, &slot->flags);
Signature · 1 line
1.7.4.1
Acked-by on v1 1/1
#1 lore raw

Friday, October 26, 2012, Jaehoon Chung <[email protected]>

Quoted 3 lines

I think right that dw_mci_setup_bus() is called into set_ios(). Actually clock is enabled at dw_mci_setup_bus() in now. Then didn't ensure to wait the 74clock.

This will be ensured when first command is sent with 'send_initialization' flag of CMD register. But I feel this change is reasonable. Looks good to me if commit message is modified.

Thanks.
Seungwon Jeon

Quoted 38 lines

To stable clock is relocated the position into dw_mci_set_ios().

---
 drivers/mmc/host/dw_mmc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mmc/host/dw_mmc.c +3 -4
index 250aa18..9001844 100644
@@ -682,9 +682,6 @@ static void __dw_mci_start_request(struct dw_mci *host,
 	if (host->pdata->select_slot)
 		host->pdata->select_slot(slot->id);
 
-	/* Slot specific timing and width adjustment */
-	dw_mci_setup_bus(slot);
-
 	host->cur_slot = slot;
 	host->mrq = mrq;
 
@@ -810,6 +807,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 	if (slot->host->drv_data->set_ios)
 		slot->host->drv_data->set_ios(slot->host, ios);
 
+	/* Slot specific timing and width adjustment */
+	dw_mci_setup_bus(slot);
+
 	switch (ios->power_mode) {
 	case MMC_POWER_UP:
 		set_bit(DW_MMC_CARD_NEED_INIT, &slot->flags);
--

1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
In reply to Jaehoon Chung
Quoted 10 lines · Jaehoon Chung

I think right that dw_mci_setup_bus() is called into set_ios(). Actually clock is enabled at dw_mci_setup_bus() in now. Then didn't ensure to wait the 74clock.
To stable clock is relocated the position into dw_mci_set_ios().

---
 drivers/mmc/host/dw_mmc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

This patch looks ok in principle, but I have trouble understanding the commit message. Would it be possible to try and reword it a bit to make it clearer?

Thanks,