Skip to contentSkip to conversation

PATCH: Remove redundant #ifdef check in arch/x86/kernel/apic/bigsmp_32.c

PATCH Sarah Nadi 1 participant 1 message Nov 1, 2012 x86

lore
Share & tools
lore

Sarah Nadi

author
#0 lore raw

From: Sarah Nadi <[email protected]>

Based on v3.5-rc1, #ifdef check in arch/x86/kernel/apic/bigsmp_32.c is redundant as SMP will always be selected for the file to compile any ways (file compiles when X86_BIGSMP is selected, and X86_BIGSMP depends on SMP). The first block is always selected, and #else code block is therefore always dead. See patch below.

arch/x86/kernel/apic/bigsmp_32.c 2012-11-01 13:54:39.501438248 -0400 renamed from arch/x86/kernel/apic/bigsmp_32.c.orig 2012-11-01 13:53:24.781158327 -0400 +0 -4
@@ -28,11 +28,7 @@ static int bigsmp_apic_id_registered(voi
 
 static const struct cpumask *bigsmp_target_cpus(void)
 {
-#ifdef CONFIG_SMP
     return cpu_online_mask;
-#else
-    return cpumask_of(0);
-#endif
 }
 
 static unsigned long bigsmp_check_apicid_used(physid_mask_t *map, int 

apicid)