Skip to contentSkip to conversation

fix awful goto: in ext4_mb_new_blocks()

PATCH Applied Eric Sandeen 2 participants 2 messages Nov 1, 2012 – Nov 8, 2012 ext4 file system

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 fix awful goto: in ext4_mb_new_blocks()

I think the whole function could be made prettier, but that goto really took the cake for too-clever-by-half.

Signed-off-by Eric Sandeen <[email protected]>

---

NB: this is just by inspection; it compiles but TBH I have not tested the actual error case handling, so it could probably use more careful eyeballing. I *think* this is equivalent.

fs/ext4/mballoc.c +7 -4
index 526e553..27f421c 100644
@@ -4310,8 +4310,10 @@ ext4_fsblk_t ext4_mb_new_blocks(handle_t *handle,
 repeat:
 		/* allocate space in core */
 		*errp = ext4_mb_regular_allocator(ac);
-		if (*errp)
+		if (*errp) {
+			ext4_discard_allocated_blocks(ac);
 			goto errout;
+		}
 
 		/* as we've just preallocated more space than
 		 * user requested orinally, we store allocated

@@ -4333,10 +4335,10 @@ repeat:
 			ac->ac_b_ex.fe_len = 0;
 			ac->ac_status = AC_STATUS_CONTINUE;
 			goto repeat;
-		} else if (*errp)
-		errout:
+		} else if (*errp) {
 			ext4_discard_allocated_blocks(ac);
-		else {
+			goto errout;
+		} else {
 			block = ext4_grp_offs_to_block(sb, &ac->ac_b_ex);
 			ar->len = ac->ac_b_ex.fe_len;
 		}

@@ -4347,6 +4349,7 @@ repeat:
 		*errp = -ENOSPC;
 	}
 
+errout:
 	if (*errp) {
 		ac->ac_b_ex.fe_len = 0;
 		ar->len = 0;
maintainer Applied
#1 lore raw
Quoted 4 lines · Eric Sandeen

I think the whole function could be made prettier, but that goto really took the cake for too-clever-by-half.

Signed-off-by Eric Sandeen <[email protected]>

Thanks, applied.

- Ted