Skip to contentSkip to conversation

myri10ge: LRO to GRO conversion

PATCH Superseded Andrew Gallatin 2 participants 2 messages Nov 14, 2012

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover myri10ge: LRO to GRO conversion

Hi,

The following patchset converts myri10ge from using the old inet_lro interface to GRO.

Note that a naive LRO->GRO conversion of myri10ge will result in a performance regression for vlan tagged frames. This is because myri10ge does not offer hardware vlan tag offload, and because GRO requires hardware vlan tag offload to aggregate vlan tagged frames.

To address this performance regression, I have implemented vlan tag popping in the myri10ge driver, as it seems to be the lesser of two evils. As [email protected] commented when I asked about this on netdev last week: "Given GRO assumes NIC does hardware vlan offloading, I guess I would chose to do that. It seems unfortunate to add vlan decap in GRO path, already very complex."

Andrew Gallatin (3):
myri10ge: Convert from LRO to GRO
myri10ge: Add vlan rx for better GRO perf.
myri10ge: Use skb_fill_page_desc().

 drivers/net/ethernet/myricom/Kconfig             |    1 -
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c |  281 
++++++----------------
 2 files changed, 80 insertions(+), 202 deletions(-)
#1 lore raw
Quoted 4 lines · Andrew Gallatin

Hi,

The following patchset converts myri10ge from using the old inet_lro interface to GRO.

Very nice work, it seems INET_LRO could die eventually ;)