Skip to contentSkip to conversation

of_mdio: Honour "status=disabled" property of device

PATCH Applied Alexander Sverdlin 3 participants 3 messages Nov 29, 2012

Subsystems (3)
Networking Network drivers Device tree
lore
Share & tools
lore

Alexander Sverdlin

author
#0 lore raw

PATCH 1/2 of_mdio: Honour "status=disabled" property of device

From: Alexander Sverdlin <[email protected]>

of_mdio: Honour "status=disabled" property of device

Currently of_mdiobus_register() function registers all PHY devices, independetly from their status property in device tree. According to "ePAPR 1.1" spec, device should only be registered if there is no "status" property, or it has "ok" (or "okay") value (see of_device_is_available()). In case of "platform devices", of_platform_device_create_pdata() checks for "status" and ensures that disabled devices are not pupulated. But such check for MDIO buses was missing until now. Fix it.

Signed-off-by Alexander Sverdlin <[email protected]>

---

drivers/of/of_mdio.c +1 -1
@@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *
 		return rc;
 
 	/* Loop over the child nodes and register a phy_device for each one */
-	for_each_child_of_node(np, child) {
+	for_each_available_child_of_node(np, child) {
 		const __be32 *paddr;
 		u32 addr;
 		int len;
Applied
#1 lore raw
Quoted 13 lines · Alexander Sverdlin

From: Alexander Sverdlin <[email protected]>

of_mdio: Honour "status=disabled" property of device

Currently of_mdiobus_register() function registers all PHY devices, independetly from their status property in device tree. According to "ePAPR 1.1" spec, device should only be registered if there is no "status" property, or it has "ok" (or "okay") value (see of_device_is_available()). In case of "platform devices", of_platform_device_create_pdata() checks for "status" and ensures that disabled devices are not pupulated. But such check for MDIO buses was missing until now. Fix it.

Quoted 2 lines
Signed-off-by Alexander Sverdlin <[email protected]>

---

Applied.

Rob

Quoted 16 lines
drivers/of/of_mdio.c +1 -1
@@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *
 		return rc;
 
 	/* Loop over the child nodes and register a phy_device for each one */
-	for_each_child_of_node(np, child) {
+	for_each_available_child_of_node(np, child) {
 		const __be32 *paddr;
 		u32 addr;
 		int len;

_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

Applied
#2 lore raw
In reply to Alexander Sverdlin
Quoted 13 lines · Alexander Sverdlin

From: Alexander Sverdlin <[email protected]>

of_mdio: Honour "status=disabled" property of device

Currently of_mdiobus_register() function registers all PHY devices, independetly from their status property in device tree. According to "ePAPR 1.1" spec, device should only be registered if there is no "status" property, or it has "ok" (or "okay") value (see of_device_is_available()). In case of "platform devices", of_platform_device_create_pdata() checks for "status" and ensures that disabled devices are not pupulated. But such check for MDIO buses was missing until now. Fix it.

Quoted 1 line
Signed-off-by Alexander Sverdlin <[email protected]>

Applied, thanks.

g.

Quoted 12 lines

---

drivers/of/of_mdio.c +1 -1
@@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *
 		return rc;
 
 	/* Loop over the child nodes and register a phy_device for each one */
-	for_each_child_of_node(np, child) {
+	for_each_available_child_of_node(np, child) {
 		const __be32 *paddr;
 		u32 addr;
 		int len;
Signature · 2 lines
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.