Skip to contentSkip to conversation

Patching eglibc for AArch64

PATCH New Marcin Juszkiewicz 3 participants 6 messages Nov 29, 2012 – Dec 10, 2012

lore
Share & tools
lore
#0 lore raw

I would like to merge AArch64 eglibc support into OE-Core. As patch is nearly 0.5MB I provide it in hrw/aarch64-support branch:

http://git.openembedded.org/openembedded-core-contrib/commit/?h=hrw/aarch64-support&id=aaa36e3ae6ff39682555ac6f21384b44d6f631e3

Commit adds two patches which add AArch64 support for 2.16 version of eglibc. Both were merged upstream but with some alterations to fit into trunk properly. As such trunk patches depend on other patches which can alter state of other architectures which I prefer to avoid.

At Linaro we do daily builds of minimal, lamp, sdk images with this patch.

commit aaa36e3ae6ff39682555ac6f21384b44d6f631e3

Author: Marcin Juszkiewicz <[email protected]>
Date:   Wed Nov 21 17:08:13 2012 +0100

eglibc: add AArch64 support

Both patches are from libc-alpha mailing list and got merged into eglibc/trunk. I can not use direct trunk commits because they already depend on other changes.

 meta/recipes-core/eglibc/eglibc-2.16/aarch64-glibc-fsf-v1-eaf6f205.patch | 15455 +
 meta/recipes-core/eglibc/eglibc-2.16/aarch64-glibc-v3-elf.patch
  |    47 +
 meta/recipes-core/eglibc/eglibc_2.16.bb
  |     6 +-
 3 files changed, 15506 insertions(+), 2 deletions(-)
#1 lore raw

W dniu 29.11.2012 12:19, Marcin Juszkiewicz pisze:

Quoted 11 lines

I would like to merge AArch64 eglibc support into OE-Core. As patch is nearly 0.5MB I provide it in hrw/aarch64-support branch:

http://git.openembedded.org/openembedded-core-contrib/commit/?h=hrw/aarch64-support&id=aaa36e3ae6ff39682555ac6f21384b44d6f631e3

Commit adds two patches which add AArch64 support for 2.16 version of eglibc. Both were merged upstream but with some alterations to fit into trunk properly. As such trunk patches depend on other patches which can alter state of other architectures which I prefer to avoid.

At Linaro we do daily builds of minimal, lamp, sdk images with this patch.

ping?

#2 lore raw
Quoted 6 lines · Marcin Juszkiewicz

W dniu 29.11.2012 12:19, Marcin Juszkiewicz pisze:

Quoted 5 lines

I would like to merge AArch64 eglibc support into OE-Core. As patch is nearly 0.5MB I provide it in hrw/aarch64-support branch:

http://git.openembedded.org/openembedded-core-contrib/commit/?h=hrw/aarch64-support&id=aaa36e3ae6ff39682555ac6f21384b44d6f631e3

Quoted 8 lines
Quoted 6 lines

Commit adds two patches which add AArch64 support for 2.16 version of eglibc. Both were merged upstream but with some alterations to fit into trunk properly. As such trunk patches depend on other patches which can alter state of other architectures which I prefer to avoid.

At Linaro we do daily builds of minimal, lamp, sdk images with this patch.

ping?

The main thing worrying me about these now is the size of the patches. I'd prefer not to add them into the main repository since they then become part of history and increase the repo size. I'd really therefore like to host the patches somewhere and then point SRC_URI at them.

Is that something linaro can do or should we find somewhere on the yoctoproject.org infrastructure?

Cheers,

Richard

#3 lore raw

W dniu 04.12.2012 11:49, Richard Purdie pisze:

Quoted 7 lines

The main thing worrying me about these now is the size of the patches. I'd prefer not to add them into the main repository since they then become part of history and increase the repo size. I'd really therefore like to host the patches somewhere and then point SRC_URI at them.

Is that something linaro can do or should we find somewhere on the yoctoproject.org infrastructure?

We can host those patches. I sent this version for review as I do development with local patchsets. Will prepare version with hosted patches.

#4 lore raw

PATCH 1/1 eglibc: add AArch64 support

---
 meta/recipes-core/eglibc/eglibc_2.16.bb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
meta/recipes-core/eglibc/eglibc_2.16.bb +5 -2
index aa9256c..e7e15a2 100644
@@ -1,7 +1,7 @@
 require eglibc.inc
 
 DEPENDS += "gperf-native kconfig-frontends-native"
-PR = "r17"
+PR = "r18"
 
 SRC_URI = "http://downloads.yoctoproject.org/releases/eglibc/eglibc-${PV}-svnr21224.tar.bz2 \
            file://eglibc-svn-arm-lowlevellock-include-tls.patch \
@@ -9,7 +9,7 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/eglibc/eglibc-${PV}-svnr21
            file://mips-rld-map-check.patch \
            file://etc/ld.so.conf \
            file://generate-supported.mk \
-	   file://glibc.fix_sqrt2.patch \
+           file://glibc.fix_sqrt2.patch \
            file://multilib_readlib.patch \
            file://use-sysroot-cxx-headers.patch \
            file://ppc-sqrt_finite.patch \
@@ -27,6 +27,9 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/eglibc/eglibc-${PV}-svnr21
            file://0001-Add-name_to_handle_at-open_by_handle-etc.-to-PowerPC.patch \
            file://fsl-ppc-no-fsqrt.patch \
            file://0001-R_ARM_TLS_DTPOFF32.patch \
+           http://people.linaro.org/~toolchain/openembedded/patches/eglibc/aarch64-0001-glibc-fsf-v1-eaf6f205.patch \
+           http://people.linaro.org/~toolchain/openembedded/patches/eglibc/aarch64-0002-Synchronize-with-linux-elf.h.patch \
+           http://people.linaro.org/~toolchain/openembedded/patches/eglibc/aarch64-0003-Adding-AArch64-support-to-elf-elf.h.patch \
           "
 
 SRC_URI[md5sum] = "88894fa6e10e58e85fbd8134b8e486a8"
Signature · 1 line
1.8.0
#5 lore raw
In reply to Marcin Juszkiewicz
Quoted 6 lines · Marcin Juszkiewicz

W dniu 29.11.2012 12:19, Marcin Juszkiewicz pisze:

Quoted 5 lines

I would like to merge AArch64 eglibc support into OE-Core. As patch is nearly 0.5MB I provide it in hrw/aarch64-support branch:

http://git.openembedded.org/openembedded-core-contrib/commit/?h=hrw/aarch64-support&id=aaa36e3ae6ff39682555ac6f21384b44d6f631e3

Quoted 8 lines
Quoted 6 lines

Commit adds two patches which add AArch64 support for 2.16 version of eglibc. Both were merged upstream but with some alterations to fit into trunk properly. As such trunk patches depend on other patches which can alter state of other architectures which I prefer to avoid.

At Linaro we do daily builds of minimal, lamp, sdk images with this patch.

ping?

Rather than importing a huge patch, can we not just provide a recipe for eglibc trunk? Or wait for a 2.17 release and roll it in then.

p.