Skip to contentSkip to conversation

dm: Update a source code comment

PATCH New Bart Van Assche 1 participant 1 message Dec 3, 2012 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm: Update a source code comment

Update a source code comment with the conclusions of the discussion of the patch that introduced this comment (commit a8c32a5). See also
http://www.redhat.com/archives/dm-devel/2012-November/msg00003.html.

Cc Jens Axboe <[email protected]>
Cc Alasdair G Kergon <[email protected]>
Cc Jun'ichi Nomura <[email protected]>
Cc Tejun Heo <[email protected]>
---
 drivers/md/dm.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/md/dm.c +1 -6
index 77e6eff..0ec0673 100644
@@ -740,12 +740,7 @@ static void rq_completed(struct mapped_device *md, int rw, int run_queue)
 	if (!md_in_flight(md))
 		wake_up(&md->wait);
 
-	/*
-	 * Run this off this callpath, as drivers could invoke end_io while
-	 * inside their request_fn (and holding the queue lock). Calling
-	 * back into ->request_fn() could deadlock attempting to grab the
-	 * queue lock again.
-	 */
+	/* run queue asynchronously to minimize time spent in soft-IRQ ctxt */
 	if (run_queue)
 		blk_run_queue_async(md->queue);
 
Signature · 1 line
1.7.10.4