Skip to contentSkip to conversation

mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined

PATCH In review Chaitanya 2 participants 3 messages Dec 5, 2012 mac80211

lore
Share & tools
lore

Chaitanya

author
#0 lore raw

PATCH 1/1 mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined

Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any new drivers to avoid messing the kernel log.

Changed the mail client to thunder bird to avoid whitespace issues. Changed the subject and also the signing off to use offical mail.

---
net/mac80211/agg-tx.c | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
net/mac80211/agg-tx.c +1 -1
index 4152ed1..eb9df22 100644
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
     trace_api_start_tx_ba_session(pubsta, tid);
 
-    if (WARN_ON(!local->ops->ampdu_action))
+    if (WARN_ON_ONCE(!local->ops->ampdu_action))
         return -EINVAL;
 
     if ((tid >= IEEE80211_NUM_TIDS) ||
maintainer
#1 lore raw

net/mac80211/agg-tx.c int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, · line 449

Quoted 9 lines · Chaitanya
net/mac80211/agg-tx.c +1 -1
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
     trace_api_start_tx_ba_session(pubsta, tid);
 
-    if (WARN_ON(!local->ops->ampdu_action))
+    if (WARN_ON_ONCE(!local->ops->ampdu_action))
         return -EINVAL;

Hm, no tabs it seems, so this doesn't apply either.

I'd just fix it myself for this simple a thing, but you'll probably eventually want to submit more complicated patches ...

johannes

author
#2 lore raw

Hmm..yes true i need to fix my environment. But i just tested this patch manually and it worked.

Let me check this once again, will fix this and send it again.

Sorry for the trouble caused.

Quoted 4 lines · Johannes Berg

Hm, no tabs it seems, so this doesn't apply either.

I'd just fix it myself for this simple a thing, but you'll probably eventually want to submit more complicated patches ...