Skip to contentSkip to conversation

mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined

PATCH In review Chaitanya 3 participants 4 messages Dec 6, 2012 mac80211

lore
Share & tools
lore

Chaitanya

author
#0 lore raw

PATCH 1/1 mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined

Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any new drivers to avoid messing the kernel log.

Changed the mail client to thunder bird to avoid whitespace issues. Changed the subject and also the signing off to use offical mail. Changed the setting for tabs (width=8, noexpandtab) and whitespaces.

Signed-off-by T Krishna Chaitanya <[email protected]>

---
net/mac80211/agg-tx.c | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
net/mac80211/agg-tx.c +1 -1
index 4152ed1..eb9df22 100644
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
     trace_api_start_tx_ba_session(pubsta, tid);
 
-    if (WARN_ON(!local->ops->ampdu_action))
+    if (WARN_ON_ONCE(!local->ops->ampdu_action))
         return -EINVAL;
 
     if ((tid >= IEEE80211_NUM_TIDS) ||
#1 lore raw
Quoted 3 lines · Chaitanya

Changed the mail client to thunder bird to avoid whitespace issues. Changed the subject and also the signing off to use offical mail. Changed the setting for tabs (width=8, noexpandtab) and whitespaces.

Don't need to mess up the change log with that.

Quoted 10 lines
Signed-off-by T Krishna Chaitanya <[email protected]>

---
net/mac80211/agg-tx.c | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
net/mac80211/agg-tx.c +0 -0
index 4152ed1..eb9df22 100644

net/mac80211/agg-tx.c int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, · line 448

Quoted 4 lines
net/mac80211/agg-tx.c +0 -1
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
     trace_api_start_tx_ba_session(pubsta, tid);
 
-    if (WARN_ON(!local->ops->ampdu_action))

^^^^^^^
Patch is still malformed (spaces instead of one tab). Before next posting to mailing list, post patch to yourself and try to apply it. Once that success, continue with mailing list posting.

Thanks
Stanislaw

author
#2 lore raw

I have tested the patch by applying it myself and it worked fine. and also in My local editor (gedit) it shows tabs.

Need to check the issue and revert.

Quoted 27 lines · Stanislaw Gruszka
Quoted 3 lines · Chaitanya

Changed the mail client to thunder bird to avoid whitespace issues. Changed the subject and also the signing off to use offical mail. Changed the setting for tabs (width=8, noexpandtab) and whitespaces.

Don't need to mess up the change log with that.

Quoted 10 lines
Signed-off-by T Krishna Chaitanya <[email protected]>

---
net/mac80211/agg-tx.c | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
net/mac80211/agg-tx.c +0 -0
index 4152ed1..eb9df22 100644

net/mac80211/agg-tx.c int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, · line 448

Quoted 4 lines
net/mac80211/agg-tx.c +0 -1
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
     trace_api_start_tx_ba_session(pubsta, tid);
 
-    if (WARN_ON(!local->ops->ampdu_action))

^^^^^^^
Patch is still malformed (spaces instead of one tab). Before next posting to mailing list, post patch to yourself and try to apply it. Once that success, continue with mailing list posting.

Thanks
Stanislaw

maintainer
#3 lore raw
Quoted 4 lines · Chaitanya

I have tested the patch by applying it myself and it worked fine. and also in My local editor (gedit) it shows tabs.

Need to check the issue and revert.

Try after it made it to you from the list -- still broken here as well.

johannes