Skip to contentSkip to conversation

IB/srp: Make SCSI error handling finish

PATCH New Bart Van Assche 1 participant 1 message Dec 7, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/srp: Make SCSI error handling finish

If a SCSI command times out it is passed to the SCSI error handler. The SCSI error handler keeps trying to abort a command until aborting succeeded or the command has been finished. Avoid that attempts to abort a command without RDMA RC connection trigger an endless loop.

Cc David Dillow <dave-i1Mk8JYDVaaSihdK6806/[email protected]>
Cc Roland Dreier <[email protected]>
Cc Or Gerlitz <[email protected]>
Cc Alex Turin <alextu-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 drivers/infiniband/ulp/srp/ib_srp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/ulp/srp/ib_srp.c +1 -1
index d5088ce..25f139b 100644
@@ -1736,7 +1736,7 @@ static int srp_abort(struct scsi_cmnd *scmnd)
 
 	shost_printk(KERN_ERR, target->scsi_host, "SRP abort called\n");
 
-	if (!req || target->qp_in_error || !srp_claim_req(target, req, scmnd))
+	if (!req || !srp_claim_req(target, req, scmnd))
 		return FAILED;
 	srp_send_tsk_mgmt(target, req->index, scmnd->device->lun,
 			  SRP_TSK_ABORT_TASK);
Signature · 6 lines
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html