Skip to contentSkip to conversation

sparc: huge_ptep_set_* functions need to call set_huge_pte_at()

PATCH Superseded Dave Kleikamp 2 participants 2 messages Dec 14, 2012 – Dec 16, 2012 SPARC + UltraSPARC (sparc/sparc64)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dave Kleikamp

author
#0 lore raw

PATCH 1/1 sparc: huge_ptep_set_* functions need to call set_huge_pte_at()

Modifying the huge pte's requires that all the underlying pte's be modified.

Signed-off-by Dave Kleikamp <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc [email protected]
---
 arch/sparc/include/asm/hugetlb.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
arch/sparc/include/asm/hugetlb.h +6 -2
index 8c5eed6..ef3fce5 100644
@@ -61,14 +61,18 @@ static inline pte_t huge_pte_wrprotect(pte_t pte)
 static inline void huge_ptep_set_wrprotect(struct mm_struct *mm,
 					   unsigned long addr, pte_t *ptep)
 {
-	ptep_set_wrprotect(mm, addr, ptep);
+	pte_t old_pte = *ptep;
+	set_huge_pte_at(mm, addr, ptep, pte_wrprotect(old_pte));
 }
 
 static inline int huge_ptep_set_access_flags(struct vm_area_struct *vma,
 					     unsigned long addr, pte_t *ptep,
 					     pte_t pte, int dirty)
 {
-	return ptep_set_access_flags(vma, addr, ptep, pte, dirty);
+	int changed = !pte_same(*ptep, pte);
+	if (changed)
+		set_huge_pte_at(vma->vm_mm, addr, ptep, pte);
+	return changed;
 }
 
 static inline pte_t huge_ptep_get(pte_t *ptep)
Signature · 1 line
1.8.0.1
maintainer
#1 lore raw

From: Dave Kleikamp <[email protected]>
Date: Fri, 14 Dec 2012 15:02:00 -0600

arch/sparc/include/asm/hugetlb.h static inline pte_t huge_pte_wrprotect(pte_t pte) · line 78

Quoted 12 lines

static inline int huge_ptep_set_access_flags(struct vm_area_struct *vma,

arch/sparc/include/asm/hugetlb.h +4 -1
 					     unsigned long addr, pte_t *ptep,
 					     pte_t pte, int dirty)
 {
-	return ptep_set_access_flags(vma, addr, ptep, pte, dirty);
+	int changed = !pte_same(*ptep, pte);
+	if (changed)
+		set_huge_pte_at(vma->vm_mm, addr, ptep, pte);
+	return changed;
 }
 
 static inline pte_t huge_ptep_get(pte_t *ptep)

This lacks the TLB flush after setting the pte, which is really needed.