Skip to contentSkip to conversation

input: Add MELFAS mms144 touchscreen driver

PATCH New Donghwa Lee 2 participants 4 messages Dec 17, 2012 – Dec 18, 2012 Input drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: Add MELFAS mms144 touchscreen driver

From: Sanggun Lee<[email protected]>

This is a TSP driver for touchscreen chip mms144 of MELFAS. It uses soft I2C interface and supports single touch.

This driver uses polling method.
If there are touch events, mms144_interrupt() reads and returns 0. If not, mms144_interrupt() returns -1.

Signed-off=by: MyungJoo Ham<[email protected]>

---
  drivers/input/Makefile |    1 +
  drivers/input/mms144.c |  202 ++++++++++++++++++++++++++++++++++++++++++++++++
  include/mms144.h       |   41 ++++++++++
  3 files changed, 244 insertions(+), 0 deletions(-)

create mode 100644 drivers/input/mms144.c
create mode 100644 include/mms144.h

drivers/input/Makefile +1 -0
index 0805e86..c802188 100644
@@ -33,6 +33,7 @@ COBJS-$(CONFIG_PS2MULT) += ps2mult.o ps2ser.o
  endif
  COBJS-y += input.o
  COBJS-$(CONFIG_OF_CONTROL) += key_matrix.o
+COBJS-$(CONFIG_MMS144) += mms144.o
  
  COBJS	:= $(COBJS-y)
  SRCS	:= $(COBJS:.o=.c)
drivers/input/mms144.c new file +202 -0

202 lines not on this page · raw message

include/mms144.h new file +41 -0

41 lines not on this page · raw message

-- 1.7.4.1

#1 lore raw

PATCH 1/1 input: Add MELFAS mms144 touchscreen driver

Dear Donghwa Lee,

Quoted 8 lines · In message <[email protected]> you wrote:

From: Sanggun Lee<[email protected]>

This is a TSP driver for touchscreen chip mms144 of MELFAS. It uses soft I2C interface and supports single touch.

This driver uses polling method.
If there are touch events, mms144_interrupt() reads and returns 0. If not, mms144_interrupt() returns -1.

Where exactly will this driver be used inside U-Boot? So far, we don't have any GUI support, do what is a touch driver good for?

Are you just adding dead code here?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see things; and you say ``Why?'' But I dream  things  that  never
were; and I say ``Why not?''
       - George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1
#2 lore raw

PATCH 1/1 input: Add MELFAS mms144 touchscreen driver

Quoted 11 lines · Wolfgang Denk

Dear Donghwa Lee,

Quoted 8 lines · In message <[email protected]> you wrote:

From: Sanggun Lee<[email protected]>

This is a TSP driver for touchscreen chip mms144 of MELFAS. It uses soft I2C interface and supports single touch.

This driver uses polling method.
If there are touch events, mms144_interrupt() reads and returns 0. If not, mms144_interrupt() returns -1.

Quoted 9 lines

Where exactly will this driver be used inside U-Boot? So far, we don't have any GUI support, do what is a touch driver good for?

Are you just adding dead code here?

Best regards,

Wolfgang Denk

From: Sanggun Lee

Hi,

We are testing various codes on TRATS board.
If this patch would be submitted, we can test the codes in a pleasant working environment.
If this driver is not used for any other purposes in the u-boot, we would use it only inside
the local tree.

Thank you,
Sanggun Lee

#3 lore raw

PATCH 1/1 input: Add MELFAS mms144 touchscreen driver

Dear Donghwa Lee,

Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Where exactly will this driver be used inside U-Boot? So far, we don't have any GUI support, do what is a touch driver good for?

...

Quoted 6 lines

We are testing various codes on TRATS board.
If this patch would be submitted, we can test the codes in a pleasant working environment.
If this driver is not used for any other purposes in the u-boot, we would use it only inside
the local tree.

As long as there is no code in mainline U-Boot that actually uses such a driver, it would only be dead code, that does not even get compile-tested. If you are going to add any such code, then please submit the driver again as part of the patch series that includes the "user".

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Confound these ancestors.... They've stolen our best ideas!"
- Ben Jonson