Skip to contentSkip to conversation

tegra_cpu_die() dead code?

DISCUSSION Stephen Warren 2 participants 2 messages Dec 19, 2012 – Dec 20, 2012 1 message not in the archive Tegra architecture support

lore
Share & tools
lore
#0 lore raw

Joseph,

In next-20121217, I see:

void __ref tegra_cpu_die(unsigned int cpu)

{
        cpu = cpu_logical_map(cpu);

        /* Flush the L1 data cache. */
        flush_cache_all();

        /* Shut down the current CPU. */
        tegra_hotplug_shutdown();

        /* Clock gate the CPU */
        tegra_wait_cpu_in_reset(cpu);
        tegra_disable_cpu_clock(cpu);
	
        /* Should never return here. */
        BUG();

Given that both implementations (Tegra20/30) of tegra_hotplug_shutdown include:

bl tegra20_cpu_shutdown
mov pc, lr @ should never get here

why does tegra_cpu_die() include the calls to tegra_wait_cpu_in_reset() and tegra_disable_cpu_clock() after calling tegra_hotplug_shutdown()? (and how can a CPU wait for itself to be in reset anyway)?

Perhaps this is fixed by the various patches you've posted but are awaiting being applied?

#2 lore raw
In reply to a message not in the archive
Quoted 24 lines · Stephen Warren

Joseph,

In next-20121217, I see:

void __ref tegra_cpu_die(unsigned int cpu)

{
        cpu = cpu_logical_map(cpu);

        /* Flush the L1 data cache. */
        flush_cache_all();

        /* Shut down the current CPU. */
        tegra_hotplug_shutdown();

        /* Clock gate the CPU */
        tegra_wait_cpu_in_reset(cpu);
        tegra_disable_cpu_clock(cpu);
	
        /* Should never return here. */
        BUG();

Given that both implementations (Tegra20/30) of tegra_hotplug_shutdown include:

Quoted 7 lines

bl tegra20_cpu_shutdown
mov pc, lr @ should never get here

why does tegra_cpu_die() include the calls to tegra_wait_cpu_in_reset() and tegra_disable_cpu_clock() after calling tegra_hotplug_shutdown()? (and how can a CPU wait for itself to be in reset anyway)?

Indeed, I had a patch to fix this. Will update to here today.

Thanks,
Joseph