3.8 NFS build breakage with !CONFIG_NFS_FSCACHE
Subsystems (2)
Hi David,
Not sure if this was report/fixed already - but as of today's Linus tree (tip has commit 96680d2), I'm seeing a build breakage due to a trivial missing def for nfs_fscache_wait_on_invalidate.
Following fixes it for me.
fs/nfs/fscache.h +0 -0
@@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct
inode *inode,
static inline void nfs_fscache_invalidate(struct inode *inode) {}
+static inline void nfs_fscache_wait_on_invalidate(struct inode *inode) {}
Thx,
-Vineet
Quoted 13 lines · Vineet Gupta
Hi David,
Not sure if this was report/fixed already - but as of today's Linus tree (tip has commit 96680d2), I'm seeing a build breakage due to a trivial missing def for
nfs_fscache_wait_on_invalidate.Following fixes it for me.
fs/nfs/fscache.h +0
-0
fs/nfs/fscache.h static inline void nfs_readpage_to_fscache(struct · line 226
Quoted 5 lines
fs/nfs/fscache.h +1
-0@@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct inode *inode, static inline void nfs_fscache_invalidate(struct inode *inode) {} +static inline void nfs_fscache_wait_on_invalidate (struct inode *inode) {}
I see the same thing here. Please write a proper patch and quote the build error in the commit message:
fs/nfs/inode.c: In function ‘nfs_invalidate_mapping’:fs/nfs/inode.c:887:2: error: implicit declaration of function ‘nfs_fscache_wait_on_invalidate’ [-Werror=implicit-function-declaration]
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--PATCH 1/1 NFS: Fix compile issue with !CONFIG_NFS_FSCACHE
fs/nfs/inode.c: In function nfs_invalidate_mapping:fs/nfs/inode.c:887: error: implicit declaration of function nfs_fscache_wait_on_invalidate
--- fs/nfs/fscache.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
fs/nfs/fscache.h +1 -0
@@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct inode *inode,static inline void nfs_fscache_invalidate (struct inode *inode) {} +static inline void nfs_fscache_wait_on_invalidate (struct inode *inode) {}static inline const char *nfs_server_fscache_state (struct nfs_server *server) {
Signature · 1 line
1.7.4.1