em28xx: module parameter prefer_bulk ?

Hi Mauro,

now that we prefer bulk transfers for webcams and isoc transfers for TV, I wonder if prefer_bulk is still a good name for this module parameter. What about something like 'usb_mode', 'usb_xfer_mode' or 'frame_xfer_mode' with 0=auto, 1=prefer isoc, 2=prefer bulk ?

Regards,
Frank

Em Mon, 24 Dec 2012 12:25:38 +0100
Frank Schäfer <[email protected]> escreveu:

while keeping it as-is is not bad, IMHO, we can change it if people prefer renaming it.

usb_xfer_mode sounds good for me. Feel free to submit a patch if you want.

It should be noticed that we can change it while it was not upstreamed.

With regards to the range, we generally use -1 for "auto" (at least, we do that on several other places).

Cheers,
Mauro

Am 24.12.2012 16:16, schrieb Mauro Carvalho Chehab:

See attachment.

Regards,
Frank

From: =?UTF-8?q?Frank=20Sch=C3=A4fer?= <[email protected]>
Date: Wed, 26 Dec 2012 19:12:37 +0100
Subject: [PATCH] em28xx: rename module parameter prefer_bulk to usb_xfer_mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Since we have now 3 modes (auto/isoc/bulk), usb_xfer_mode is more suitable than prefer_bulk.

---
 drivers/media/usb/em28xx/em28xx-cards.c |   11 ++++++-----

1 Datei geändert, 6 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-)

index a0eed7e..c5e1d2d 100644
@@ -61,9 +61,10 @@ static unsigned int card[]     = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
 module_param_array(card,  int, NULL, 0444);
 MODULE_PARM_DESC(card,     "card type");
 
-static int prefer_bulk = -1;
-module_param(prefer_bulk, int, 0444);
-MODULE_PARM_DESC(prefer_bulk, "prefer USB bulk transfers (-1 = auto, 0 = isoc, 1 = bulk)");
+static int usb_xfer_mode = -1;
+module_param(usb_xfer_mode, int, 0444);
+MODULE_PARM_DESC(usb_xfer_mode,
+		 "USB transfer mode for frame data (-1 = auto, 0 = prefer isoc, 1 = prefer bulk)");
 
 
 /* Bitmask marking allocated devices from 0 to EM28XX_MAXBOARDS - 1 */

@@ -3399,13 +3400,13 @@ static int em28xx_usb_probe(struct usb_interface *interface,
 		goto unlock_and_free;
 	}
 
-	if (prefer_bulk < 0) {
+	if (usb_xfer_mode < 0) {
 		if (dev->board.is_webcam)
 			try_bulk = 1;
 		else
 			try_bulk = 0;
 	} else {
-		try_bulk = prefer_bulk > 0;
+		try_bulk = usb_xfer_mode > 0;
 	}
 
 	/* Select USB transfer types to use */

1.7.10.4