Skip to contentSkip to conversation

Fix possible (unlikely) buffer overflow

PATCH In review Thomas Jarosch 1 participant 2 messages Dec 25, 2012 – Jan 25, 2013 perf events

lore
Share & tools
lore

Thomas Jarosch

author
#0 lore raw

PATCH 1/1 Fix possible (unlikely) buffer overflow

cppcheck reported:
[tools/perf/util/sysfs.c:50]: (error) Width 4096 given in format string (no. 1) is larger than destination buffer 'sysfs_mountpoint[4096]', use %4095s to prevent overflowing it

-> All other places in the kernel that use STR(PATH_MAX)
have a buffer size of PATH_MAX+1.

Signed-off-by Thomas Jarosch <[email protected]>
---
 tools/perf/util/sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/sysfs.c +1 -1
index 48c6902..606f884 100644
@@ -8,7 +8,7 @@ static const char * const sysfs_known_mountpoints[] = {
 };
 
 static int sysfs_found;
-char sysfs_mountpoint[PATH_MAX];
+char sysfs_mountpoint[PATH_MAX+1];
 
 static int sysfs_valid_mountpoint(const char *sysfs)
 {
Signature · 1 line
1.7.11.7
author
#1 lore raw

[tip:perf/core] perf tools: Fix possible (unlikely) buffer overflow

Commit-ID:  a65c23420668f7112395abf9c6f22c6450567bf0
Gitweb:     http://git.kernel.org/tip/a65c23420668f7112395abf9c6f22c6450567bf0
Author:     Thomas Jarosch <[email protected]>
AuthorDate: Tue, 25 Dec 2012 17:23:39 +0100
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 24 Jan 2013 16:40:18 -0300

perf tools: Fix possible (unlikely) buffer overflow

cppcheck reported:
[tools/perf/util/sysfs.c:50]: (error) Width 4096 given in format string (no. 1) is larger than destination buffer 'sysfs_mountpoint[4096]', use %4095s to prevent overflowing it

-> All other places in the kernel that use STR(PATH_MAX)
have a buffer size of PATH_MAX + 1.

Signed-off-by Thomas Jarosch <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/sysfs.c +1 -1
index 48c6902..f71e9ea 100644
@@ -8,7 +8,7 @@ static const char * const sysfs_known_mountpoints[] = {
 };
 
 static int sysfs_found;
-char sysfs_mountpoint[PATH_MAX];
+char sysfs_mountpoint[PATH_MAX + 1];
 
 static int sysfs_valid_mountpoint(const char *sysfs)
 {