fs/ext*,f2fs,jffs2,reiserfs: give comments for aclsize and count calculation
------- Original Message -------
From: Jan Kara <[email protected]>
To: Chen Gang <[email protected]>
Cc: [email protected]; [email protected];[email protected]; Theodore Tso <[email protected]>;[email protected]; [email protected];[email protected]; [email protected];[email protected];[email protected]; [email protected]
Sent: Mon, 31 Dec 2012 16:45:59 +0100
Subject: Re: [PATCH] fs/ext*,f2fs,jffs2,reiserfs: give comments for aclsize and count calculation
Quoted 5 lines
I agree that defining a constant for this makes sence. Just please be
more verbose with the comment. This is hardly readable for anyone not knowing what's going on in advance. Also braces around 4 are superfluous. Add something like the comment below beforeposix_acl_valid():
thank for your suggestions.
Quoted 8 lines
/*
*posix_acl_valid()makes sure ACL format is the following:
*ACL_USER_OBJACL_USER*[1]ACL_GROUP_OBJACL_GROUP*[1] ACL_MASK[2]ACL_OTHER*
* [1] Where * is the regexp sense of "0 or more times"
* [2] IfACL_USERorACL_GROUPis present, thenACL_MASKmust be present. */
Quoted 7 lines
Then add comment before definition of
ACL_MAX_SHORT_ENTRY:
/*
*posix_acl_valid()makes sure that if there are <= 4 ACL entries, then
* all of them are short. Otherwise exactly 4 entries are short ones and
* other have full length. See comment before that function for exact ACL
* format.
*/
I will send patch v2 which include the contents which you provide.
and also add Signed-of-by Jan Kara <[email protected]>
thanks.