configure: silencing pkg-config's check for curses

PATCH Superseded Vadim Evard 3 participants 5 messages Jan 15, 2013 – Jan 17, 2013

lore

Share & tools

lore

Vadim Evard

author

2013-01-15 23:53 UTC #0 lore raw

PATCH 1/1 configure: silencing pkg-config's check for curses

Quoted 1 line

From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001

From: Vadim Evard <[email protected]>
Date: Wed, 16 Jan 2013 03:45:44 +0400
Subject: [PATCH] configure: silencing pkg-config's check for curses

---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

configure +1 -1

index 4ebb60d..6211db9 100755
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then

Signature · 1 line

1.7.10.4

Stefan Hajnoczi

Reviewed-by on v1 1/1

2013-01-16 09:28 UTC #1 lore raw

Quoted 8 lines · Vadim Evard

From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
From: Vadim Evard <[email protected]>
Date: Wed, 16 Jan 2013 03:45:44 +0400
Subject: [PATCH] configure: silencing pkg-config's check for curses
---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Probably best if Anthony or another qemu.git committer applies this straight away instead of waiting for the next qemu-trivial pull request.

Reviewed-by Stefan Hajnoczi <[email protected]>

Anthony Liguori

2013-01-16 14:55 UTC #2 lore raw

In reply to Vadim Evard

Quoted 4 lines · Vadim Evard

Quoted 1 line
From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
From: Vadim Evard <[email protected]>
Date: Wed, 16 Jan 2013 03:45:44 +0400
Subject: [PATCH] configure: silencing pkg-config's check for curses

This is fubar above and it's missing a Signed-off-by. Please CC me when you send out a new version that fixes this.

Regards,

Anthony Liguori

Quoted 20 lines

---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

configure +1 -1

index 4ebb60d..6211db9 100755
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then

Signature · 1 line

1.7.10.4

Vadim Evard

author

2013-01-16 20:17 UTC #3 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

Signed-off-by Vadim Evard <[email protected]>

---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

configure +1 -1

index 4ebb60d..6211db9 100755
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then

Signature · 1 line

1.7.10.4

Anthony Liguori

2013-01-17 20:01 UTC #4 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

Quoted 1 line · Vadim Evard

Signed-off-by Vadim Evard <[email protected]>

Please post this as a top-level patch. (no in-reply-to)

Regards,

Anthony Liguori

Quoted 19 lines

---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

configure +1 -1

index 4ebb60d..6211db9 100755
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then

Signature · 1 line

1.7.10.4