Skip to contentSkip to conversation

EHCI: Update qTD next pointer in QH overlay region during unlink

REVERT Joseph Salisbury 3 participants 10 messages Jan 17, 2013 – Feb 6, 2013 Stable branch

lore
Share & tools
lore
#0 lore raw

Hello,

Please consider reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the current stable releases. It was included upstream as of v3.6-rc6. This commit introduced a regression, described in the following bug report:

http://bugs.launchpad.net/bugs/1088733

Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 kernel has been confirmed to resolve the aforementioned bug.

Sincerely,

Joseph Salisbury

#1 lore raw
Quoted 8 lines · Joseph Salisbury

Hello,

Please consider reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the current stable releases. It was included upstream as of v3.6-rc6. This commit introduced a regression, described in the following bug report:

Quoted 4 lines

http://bugs.launchpad.net/bugs/1088733

Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 kernel has been confirmed to resolve the aforementioned bug.

If it's wrong in mainline then the revert needs to be done there and cc'd to stable. We only revert directly in stable branches if the revert is not appropriate in mainline.

Ben.

Signature · 3 lines
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus
#2 lore raw
Quoted 11 lines · Ben Hutchings
Quoted 10 lines · Joseph Salisbury

Hello,

Please consider reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the current stable releases. It was included upstream as of v3.6-rc6. This commit introduced a regression, described in the following bug report:

http://bugs.launchpad.net/bugs/1088733

Quoted 9 lines
Quoted 2 lines

Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 kernel has been confirmed to resolve the aforementioned bug.

If it's wrong in mainline then the revert needs to be done there and cc'd to stable. We only revert directly in stable branches if the revert is not appropriate in mainline.

Ben.

Hi Ben,

Understood. Thanks for the feedback. I'll resend as a patch to mainline.

Thanks,

Joe

#3 lore raw
In reply to Joseph Salisbury
Quoted 11 lines · Joseph Salisbury

Hello,

Please consider reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the current stable releases. It was included upstream as of v3.6-rc6. This commit introduced a regression, described in the following bug report:

http://bugs.launchpad.net/bugs/1088733

Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 kernel has been confirmed to resolve the aforementioned bug.

I do not want to revert this commit without first understanding what is going wrong. Please ask the reporter to post usbmon traces showing what happens in both a failed and a successful recording attempt.

Alan Stern

#4 lore raw
Quoted 11 lines · Alan Stern
Quoted 9 lines · Joseph Salisbury

Hello,

Please consider reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the current stable releases. It was included upstream as of v3.6-rc6. This commit introduced a regression, described in the following bug report:

http://bugs.launchpad.net/bugs/1088733

Quoted 8 lines
Quoted 2 lines

Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 kernel has been confirmed to resolve the aforementioned bug.

I do not want to revert this commit without first understanding what is going wrong. Please ask the reporter to post usbmon traces showing what happens in both a failed and a successful recording attempt.

Alan Stern

Will do. Thanks, Alan.

#5 lore raw
In reply to Alan Stern
Quoted 11 lines · Alan Stern
Quoted 9 lines · Joseph Salisbury

Hello,

Please consider reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the current stable releases. It was included upstream as of v3.6-rc6. This commit introduced a regression, described in the following bug report:

http://bugs.launchpad.net/bugs/1088733

Quoted 8 lines
Quoted 2 lines

Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 kernel has been confirmed to resolve the aforementioned bug.

I do not want to revert this commit without first understanding what is going wrong. Please ask the reporter to post usbmon traces showing what happens in both a failed and a successful recording attempt.

Alan Stern

Hi Alan,

There is a tar file[0] attached to the bug report[1]. The tar file contains a few examples of failed and successful recording attempts while collecting usbmon traces. There is a readme.txt file available after extracting the files.

The bug reporter states that only the first recording after boot fails. Subsequent recordings succeed will succeed.

Thanks again for reviewing this, Alan. Just let me know if you would like any additional data or testing.

Thanks,

Joe

[0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733

#6 lore raw
Quoted 13 lines · Joseph Salisbury

Hi Alan,

There is a tar file[0] attached to the bug report[1]. The tar file contains a few examples of failed and successful recording attempts while collecting usbmon traces. There is a readme.txt file available after extracting the files.

The bug reporter states that only the first recording after boot fails. Subsequent recordings succeed will succeed.

Thanks again for reviewing this, Alan. Just let me know if you would like any additional data or testing.

Quoted 7 lines

Thanks,

Joe

[0]
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733

I have replied to the original report at bugs.launchpad.net with a diagnostic patch. Maybe it will help indicate what's going wrong.

Alan Stern

#7 lore raw
Quoted 19 lines · Alan Stern
Quoted 17 lines · Joseph Salisbury

Hi Alan,

There is a tar file[0] attached to the bug report[1]. The tar file contains a few examples of failed and successful recording attempts while collecting usbmon traces. There is a readme.txt file available after extracting the files.

The bug reporter states that only the first recording after boot fails. Subsequent recordings succeed will succeed.

Thanks again for reviewing this, Alan. Just let me know if you would like any additional data or testing.

Thanks,

Joe

Quoted 8 lines
Quoted 3 lines

[0]
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733

I have replied to the original report at bugs.launchpad.net with a diagnostic patch. Maybe it will help indicate what's going wrong.

Alan Stern

Thanks so much for the assistance, Alan. I'll work with the bug reporter to build a kernel with the patch and test.

Joe

#8 lore raw
Quoted 7 lines · Joseph Salisbury
Quoted 5 lines

I have replied to the original report at bugs.launchpad.net with a diagnostic patch. Maybe it will help indicate what's going wrong.

Alan Stern

Thanks so much for the assistance, Alan. I'll work with the bug reporter to build a kernel with the patch and test.

The bug reporter may not need any help, considering that he was already able to carry out a git bisection search.

Alan Stern

#9 lore raw
In reply to Alan Stern
Quoted 25 lines · Alan Stern
Quoted 13 lines · Joseph Salisbury

Hi Alan,

There is a tar file[0] attached to the bug report[1]. The tar file contains a few examples of failed and successful recording attempts while collecting usbmon traces. There is a readme.txt file available after extracting the files.

The bug reporter states that only the first recording after boot fails. Subsequent recordings succeed will succeed.

Thanks again for reviewing this, Alan. Just let me know if you would like any additional data or testing.

Quoted 7 lines

Thanks,

Joe

[0]
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733

I have replied to the original report at bugs.launchpad.net with a diagnostic patch. Maybe it will help indicate what's going wrong.

Quoted 7 lines

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Hi Alan,

The bug reporter collected some data[0] using your diagnostic patch.

Thanks again for all your help.

Joe

[0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3516533/+files/usbmon-diag-1088733.tar.gz