Skip to contentSkip to conversation

Possible 'prev' leakage in nfs41_walk_client_list

DISCUSSION Ben Greear 1 participant 1 message Jan 18, 2013

Subsystems (2)
lore
Share & tools
lore

Ben Greear

author
#0 lore raw

[ A private conversation resulted in a 'if you can't show the problem in a real test case, then we don't need a patch' response, so I'm posting publicly in case someone else wants to cook up a patch. ]

While looking at the code, I noticed that the nfs40 version has some code to release 'prev' in the failure case, but nfs41 version does not.

The code is complicated, but I believe prev can indeed leak in this method, if the failure case code path is taken. I have no proof that the failure case is ever taken, but the 'nfs40' version failure case can...

Perhaps someone more familiar with this code can cook up a fix.

I'm not using this code in my test right now, so I have no good way to test a patch at this point.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com