Skip to contentSkip to conversation

KBUILD EXTMOD: Don't echo test -e for autoconf.h, even in verbose mode

PATCH New Daniel Dadap 1 participant 1 message Jan 24, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KBUILD EXTMOD: Don't echo test -e for autoconf.h, even in verbose mode

The top-level Makefile tests to make sure autoconf.h is present before building external modules. This test is performed silently unless KBUILD_VERBOSE is set, in which case the test, along with the error messages that gets printed when the test fails, shows up in make output, regardless of whether the test succeeds.

Although there may be some utility in actually printing the test along with the error message when building with KBUILD_VERBOSE, in practice, the error message can confuse people building external modules.

---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 07bc925..11f1e69 100644
@@ -537,7 +537,7 @@ else
 PHONY += include/config/auto.conf
 
 include/config/auto.conf:
-    $(Q)test -e include/generated/autoconf.h -a -e $@ || (        \
+    @test -e include/generated/autoconf.h -a -e $@ || (        \
     echo;                                \
     echo "  ERROR: Kernel configuration is invalid.";        \
     echo "         include/generated/autoconf.h or $@ are missing.";\
Signature · 8 lines
1.7.10.4

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------