libata: fix smatch warning for zpodd_wake_dev

PATCH New Aaron Lu 1 participant 1 message Jan 28, 2013 libata

Share & tools

Aaron Lu

author

2013-01-28 05:07 UTC #0 lore raw

PATCH 1/1 libata: fix smatch warning for zpodd_wake_dev

Fix a smatch warning caused by an useless pointer check.
The context parameter (aka. ata_dev) will never be NULL until we remove the acpi notification handler, so it is pointless to check it for NULL.

Reported-by Dan Carpenter <[email protected]>

Signed-off-by Aaron Lu <[email protected]>

---
 drivers/ata/libata-zpodd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/ata/libata-zpodd.c +1 -2

index 540b0b7..7c0204a 100644
@@ -239,8 +239,7 @@ static void zpodd_wake_dev(acpi_handle handle, u32 event, void *context)
 	struct zpodd *zpodd = ata_dev->zpodd;
 	struct device *dev = &ata_dev->sdev->sdev_gendev;
 
-	if (event == ACPI_NOTIFY_DEVICE_WAKE && ata_dev &&
-			pm_runtime_suspended(dev)) {
+	if (event == ACPI_NOTIFY_DEVICE_WAKE && pm_runtime_suspended(dev)) {
 		zpodd->from_notify = true;
 		pm_runtime_resume(dev);
 	}

Signature · 1 line

1.8.1