Skip to contentSkip to conversation

APEI: ERST table in ACPI NVS not supported

DISCUSSION Max Asbock 2 participants 4 messages Jan 29, 2013 – Feb 5, 2013 ACPI

lore
Share & tools
lore

Max Asbock

author
#0 lore raw

Hi,

we have systems that declare the memory range for ERST in ACPI NVS.
Because ACPI NVS is marked 'busy' by e820_reserve_resources() the call to request_mem_region(erst_erange.base, erst_erange.size, "APEI ERST") made from erst_init() fails and we get:
ERST: Can not request iomem region <0x 7e91f000-0x 7e920c00> for ERST.

I did notice that quite some effort was made to add code to avoid resource conflicts between APEI and ACPI NVS. But ERST still goes straight to request_mem_region() which is bound to fail. I am assuming this should go through apei_resources_request() instead or I am missing something?

thanks,
Max

#1 lore raw
Quoted 17 lines · Max Asbock

Date: Tue, 29 Jan 2013 10:08:11 -0800
From: Max Asbock <[email protected]>
To: [email protected], [email protected]
CC: [email protected], [email protected]
Subject: APEI: ERST table in ACPI NVS not supported
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108
Thunderbird/10.0.12

Hi,

we have systems that declare the memory range for ERST in ACPI NVS. Because ACPI NVS is marked 'busy' by e820_reserve_resources() the call to request_mem_region(erst_erange.base, erst_erange.size, "APEI ERST") made from erst_init() fails and we get:
ERST: Can not request iomem region <0x 7e91f000-0x
7e920c00> for ERST.

Quoted 6 lines

I did notice that quite some effort was made to add code to avoid resource conflicts between APEI and ACPI NVS. But ERST still goes straight to request_mem_region() which is bound to fail. I am assuming this should go through apei_resources_request() instead or I am missing something?

If my understanding is right, after ERST resource is requested via apei_resources_request and when requesting error log address range, you meet an NVS conflict, right?

If so, NVS must be excluded. But I'm afraid if error range is separated into two parts thus some errors will be lost. Would you please paste errage address range and conflicted NVS range?

Quoted 3 lines

thanks,
Max

author
#2 lore raw
Quoted 16 lines · Chen Gong

On Tue, Jan 29, 2013 at 10:08:11AM -0800, Max Asbock wrote:

we have systems that declare the memory range for ERST in ACPI NVS. Because ACPI NVS is marked 'busy' by e820_reserve_resources() the call to request_mem_region(erst_erange.base, erst_erange.size, "APEI ERST") made from erst_init() fails and we get:
ERST: Can not request iomem region<0x 7e91f000-0x
7e920c00> for ERST.

I did notice that quite some effort was made to add code to avoid resource conflicts between APEI and ACPI NVS. But ERST still goes straight to request_mem_region() which is bound to fail. I am assuming this should go through apei_resources_request() instead or I am missing something?

Quoted 7 lines

If my understanding is right, after ERST resource is requested via apei_resources_request and when requesting error log address range, you meet an NVS conflict, right?

If so, NVS must be excluded. But I'm afraid if error range is separated into two parts thus some errors will be lost. Would you please paste errage address range and conflicted NVS range?

ACPI NVS is:

[    0.000000] BIOS-e820: [mem 0x000000007e6a5000-0x000000007ebc5fff] ACPI NVS

ERST erange is:

0x7e91f000-0x7e920c00

which is a single range entirely within ACPI NVS.

thanks,
Max

#3 lore raw
Quoted 37 lines · Max Asbock

Date: Mon, 04 Feb 2013 09:06:24 -0800
From: Max Asbock <[email protected]>
To: [email protected], [email protected], [email protected],
[email protected]
Subject: Re: APEI: ERST table in ACPI NVS not supported
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108
Thunderbird/10.0.12

Quoted 16 lines · Chen Gong

On Tue, Jan 29, 2013 at 10:08:11AM -0800, Max Asbock wrote:

we have systems that declare the memory range for ERST in ACPI NVS. Because ACPI NVS is marked 'busy' by e820_reserve_resources() the call to request_mem_region(erst_erange.base, erst_erange.size, "APEI ERST") made from erst_init() fails and we get:
ERST: Can not request iomem region<0x 7e91f000-0x
7e920c00> for ERST.

I did notice that quite some effort was made to add code to avoid resource conflicts between APEI and ACPI NVS. But ERST still goes straight to request_mem_region() which is bound to fail. I am assuming this should go through apei_resources_request() instead or I am missing something?

Quoted 7 lines

If my understanding is right, after ERST resource is requested via apei_resources_request and when requesting error log address range, you meet an NVS conflict, right?

If so, NVS must be excluded. But I'm afraid if error range is separated into two parts thus some errors will be lost. Would you please paste errage address range and conflicted NVS range?

ACPI NVS is:

[    0.000000] BIOS-e820: [mem

0x000000007e6a5000-0x000000007ebc5fff] ACPI NVS

Quoted 9 lines

ERST erange is:

0x7e91f000-0x7e920c00

which is a single range entirely within ACPI NVS.

thanks,
Max

If so, ERST erange can't be allocated. It looks like a BIOS bug. I think your concern is meaningful but as I said, erange means the whole ERST table entries, which means any overlap will cause part of error records are lost. So the safest way is to refuse the allocation for such type of range.