ptp: PTP_1588_CLOCK_PCH depends on x86
Subsystems (2)
PATCH 1/1 ptp: PTP_1588_CLOCK_PCH depends on x86
The EG20T PCH is only compatible with Intel Atom processors so it should depend on x86.
--- drivers/ptp/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/ptp/Kconfig +1 -0
@@ -72,6 +72,7 @@ config DP83640_PHY config PTP_1588_CLOCK_PCH tristate "Intel PCH EG20T as PTP clock" + depends on X86 select PTP_1588_CLOCK help This driver adds support for using the PCH EG20T as a PTP
Signature · 2 lines
Jeff Mahoney SUSE Labs
Richard Cochran
maintainerQuoted 2 lines · Jeff Mahoney
The EG20T PCH is only compatible with Intel Atom processors so it should depend on x86.
Yes, there is something wrong with PTP_1588_CLOCK_PCH. The last several times I did 'make oldconfig' for various configs, it asked me whether to enable this 'new' option. That is really annoying, especially with non-atom and non-x86 builds.
Ben, you removed the PCH_GBE dependency in 18d359ce. Are you sure that was the right thing to do?
Thanks,
Richard
Quoted 20 lines
Cc Richard Cochran <[email protected]>Signed-off-by Jeff Mahoney <[email protected]>--- drivers/ptp/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/ptp/Kconfig +1
-0@@ -72,6 +72,7 @@ config DP83640_PHY config PTP_1588_CLOCK_PCH tristate "Intel PCH EG20T as PTP clock" + depends on X86 select PTP_1588_CLOCK help This driver adds support for using the PCH EG20T as a PTPSignature · 3 lines
-- Jeff Mahoney SUSE Labs
Quoted 11 lines · Richard Cochran
Quoted 2 lines · Jeff Mahoney
The EG20T PCH is only compatible with Intel Atom processors so it should depend on x86.
Yes, there is something wrong with
PTP_1588_CLOCK_PCH. The last several times I did 'make oldconfig' for various configs, it asked me whether to enable this 'new' option. That is really annoying, especially with non-atom and non-x86 builds.Ben, you removed the
PCH_GBEdependency in18d359ce. Are you sure that was the right thing to do?
The clock is a separate device and the PHC driver doesn't depend on the net driver. However, since the clock is a PCI device the driver does need a dependency on PCI (which was previously an indirect dependency).
Quoted 10 lines
Quoted 10 lines
Cc Richard Cochran <[email protected]>Signed-off-by Jeff Mahoney <[email protected]>--- drivers/ptp/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/ptp/Kconfig +0
-0@@ -72,6 +72,7 @@ config DP83640_PHY
Quoted 6 lines
drivers/ptp/Kconfig config DP83640_PHY · line 78
Quoted 6 lines
drivers/ptp/Kconfig +1
-0config PTP_1588_CLOCK_PCH tristate "Intel PCH EG20T as PTP clock" + depends on X86 select PTP_1588_CLOCK help This driver adds support for using the PCH EG20T as a PTP
I agree that the driver is only useful on X86, but some people like to build-test as many drivers as possible with a single configuration. The only build dependency for this seems to be PCI.
(Putting on my distribution hat for a moment: it is useful to know that a driver is practically architecture-specific even though it can be built elsewhere. Perhaps there is a use for a BUILD_TEST or BUILD_ALL config symbol, so this could be:
depends on X86 || (BUILD_TEST && PCI)
)
Ben.
Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.