fix portability issues encountered while building against musl libc
PATCH 1/1 fix portability issues encountered while building against musl libc
2 header inclusions were missing, one for PATH_MAX (limits.h) and one for FD_ZERO, FD_SET, ... (sys/select.h)
on glibc, those headers are erroneusly (namespace pollution) pulled in through other headers, so the author didnt notice.
lib/utils_devpath.c +1 -0
@@ -28,6 +28,7 @@#include <dirent.h> #include <fcntl.h> #include <errno.h> +#include <limits.h> #include <sys/stat.h> #include <sys/types.h> #include "utils_dm.h"
lib/random.c +1 -0
@@ -23,6 +23,7 @@#include <fcntl.h> #include <errno.h> #include <assert.h> +#include <sys/select.h> #include "libcryptsetup.h" #include "internal.h"
Quoted 5 lines · John Spencer
2 header inclusions were missing, one for
PATH_MAX(limits.h) and one forFD_ZERO,FD_SET, ... (sys/select.h)on glibc, those headers are erroneusly (namespace pollution) pulled in through other headers, so the author didnt notice.
Both patches applied, thanks.
BTW which environment (libc) are you using?
Milan
Quoted 8 lines · Milan Broz
Quoted 5 lines · John Spencer
2 header inclusions were missing, one for
PATH_MAX(limits.h) and one forFD_ZERO,FD_SET, ... (sys/select.h)on glibc, those headers are erroneusly (namespace pollution) pulled in through other headers, so the author didnt notice.
Both patches applied, thanks.
thanks!
Quoted 2 lines
BTW which environment (libc) are you using?
musl libc: http://www.musl-libc.org/
best regards,
--JS
Quoted 7 lines
Milan
_______________________________________________
dm-crypt mailing list
[email protected]
http://www.saout.de/mailman/listinfo/dm-crypt